Fix the notices when creating AWS Cloud service provider

@jigishaddweb

Thank you for providing the patch. Could you please change the following code?

FROM:

--- a/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php
+++ b/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php
@@ -441,6 +441,11 @@ class Ec2BatchOperations {

+    $allocation_id = NULL;
+    if (isset($network_interface['Association'])) {
+      $allocation_id = $network_interface['Association']['AllocationId'] ?? NULL;
+    }

TO:

+    $allocation_id = NULL;
+    if (!empty($network_interface['Association'])) {
+      $allocation_id = $network_interface['Association']['AllocationId'] ?? NULL;
+    }

@jigish, Thank you for supplying this patch. When I'm testing with my EC2 account, I encountered some more PHP warnings.

Can you please fix these in the patch too?

Notice: Undefined index: Iops in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateVolume() (line 897 of /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php) 

Notice: Undefined index: PrivateDnsName in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateNetworkInterface() (line 481 of /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php)

Notice: Undefined index: Attachment in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateNetworkInterface() (line 496 of /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php)

Notice: Undefined index: VpcId in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateSecurityGroup() (line 348 of /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php)

Notice: Undefined index: client_secret in Google_Client->setAuthConfig() (line 900 of /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/vendor/google/apiclient/src/Google/Client.php) #0 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/includes/bootstrap.inc(587): _drupal_error_handler_real(8, 'Undefined index...', '/mnt/ssd1/Devel...', 900, Array) #1 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/vendor/google/apiclient/src/Google/Client.php(900): _drupal_error_handler(8, 'Undefined index...', '/mnt/ssd1/Devel...', 900, Array) #2 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Pricing/GoogleSpreadsheetService.php(345): Google_Client->setAuthConfig(Array) #3 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Pricing/GoogleSpreadsheetService.php(99): Drupal\aws_cloud\Service\Pricing\GoogleSpreadsheetService->getClient() #4 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/aws_cloud.module(590): Drupal\aws_cloud\Service\Pricing\GoogleSpreadsheetService->createOrUpdate(NULL, 'us-west-2', 'AWS Cloud Insta...') #5 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/aws_cloud.module(530): aws_cloud_create_or_update_pricing_spreadsheet(Object(Drupal\cloud\Entity\CloudConfig)) #6 [internal function]: aws_cloud_cloud_config_presave(Object(Drupal\cloud\Entity\CloudConfig)) #7 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(403): call_user_func_array('aws_cloud_cloud...', Array) #8 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(204): Drupal\Core\Extension\ModuleHandler->invokeAll('cloud_config_pr...', Array) #9 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(835): Drupal\Core\Entity\EntityStorageBase->invokeHook('presave', Object(Drupal\cloud\Entity\CloudConfig)) #10 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(492): Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('presave', Object(Drupal\cloud\Entity\CloudConfig)) #11 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(692): Drupal\Core\Entity\EntityStorageBase->doPreSave(Object(Drupal\cloud\Entity\CloudConfig)) #12 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(446): Drupal\Core\Entity\ContentEntityStorageBase->doPreSave(Object(Drupal\cloud\Entity\CloudConfig)) #13 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(838): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\cloud\Entity\CloudConfig)) #14 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityBase.php(394): Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object(Drupal\cloud\Entity\CloudConfig)) #15 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/src/Entity/CloudContentEntityBase.php(136): Drupal\Core\Entity\EntityBase->save() #16

	Notice: Undefined index: client_id in Google_Client->setAuthConfig() (line 899 of /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/vendor/google/apiclient/src/Google/Client.php) #0 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/includes/bootstrap.inc(587): _drupal_error_handler_real(8, 'Undefined index...', '/mnt/ssd1/Devel...', 899, Array) #1 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/vendor/google/apiclient/src/Google/Client.php(899): _drupal_error_handler(8, 'Undefined index...', '/mnt/ssd1/Devel...', 899, Array) #2 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Pricing/GoogleSpreadsheetService.php(345): Google_Client->setAuthConfig(Array) #3 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Pricing/GoogleSpreadsheetService.php(99): Drupal\aws_cloud\Service\Pricing\GoogleSpreadsheetService->getClient() #4 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/aws_cloud.module(590): Drupal\aws_cloud\Service\Pricing\GoogleSpreadsheetService->createOrUpdate(NULL, 'us-west-2', 'AWS Cloud Insta...') #5 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/aws_cloud.module(530): aws_cloud_create_or_update_pricing_spreadsheet(Object(Drupal\cloud\Entity\CloudConfig)) #6 [internal function]: aws_cloud_cloud_config_presave(Object(Drupal\cloud\Entity\CloudConfig)) #7 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(403): call_user_func_array('aws_cloud_cloud...', Array) #8 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(204): Drupal\Core\Extension\ModuleHandler->invokeAll('cloud_config_pr...', Array) #9 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(835): Drupal\Core\Entity\EntityStorageBase->invokeHook('presave', Object(Drupal\cloud\Entity\CloudConfig)) #10 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(492): Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('presave', Object(Drupal\cloud\Entity\CloudConfig)) #11 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(692): Drupal\Core\Entity\EntityStorageBase->doPreSave(Object(Drupal\cloud\Entity\CloudConfig)) #12 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(446): Drupal\Core\Entity\ContentEntityStorageBase->doPreSave(Object(Drupal\cloud\Entity\CloudConfig)) #13 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(838): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\cloud\Entity\CloudConfig)) #14 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/core/lib/Drupal/Core/Entity/EntityBase.php(394): Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object(Drupal\cloud\Entity\CloudConfig)) #15 /mnt/ssd1/Devel/Docomo/cloud.drupal.dev/web/modules/contrib/cloud/src/Entity/CloudContentEntityBase.php(136): Drupal\Core\Entity\EntityBase->save() #16

@baldwinlouie I am assigning this to me to work on the above issue.

I fixed notices in Ec2BatchOperations.php please review patch.

@swatichouhan, Thank you for supplying this patch. When I have installed the module for the same i found some issues which i have attached the screenshot. it is throwing "Error: Class 'Aws\Endpoint\EndpointProvider' not found in Drupal\aws_cloud\Service\Ec2\Ec2Service->getEndpointUrls() (line 784 of /var/www/html/contrib/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2Service.php)".

Please find the steps to reproduce the issue
1. install the cloud module with same version (8.x-2.x-dev)
2. install one of the cloud service providers which will be present within the Cloud module as shown in screenshot (aws_cloud.png)
3. go to "admin/config/services/cloud/aws_cloud"
4. click "Add Profile" as shown in the screenshot (cloud_error.png)
5. check the drupal admin console (drupal_console.png)

@Rithesh, please make sure to install the AWS PHP SDK as defined in the README.md file, in the installation section. The easiest way is to use composer to download and install the library.

@swatichouhan and @jigish,

Thank you for the updated patch. There is one more warning to fix. Please see attached screenshot.

@jigish, Thank you for the patch. I ran the patch locally, and found some more issues.

See screenshot, which happens during a refresh.

Secondly on line 205:

        'private_dns' => $instance['PrivateDnsName'],

we should be checking for NULL

Finally, when adding a new cloud service provider, I encountered the following errors

Notice: Undefined index: VpcId in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateInstance() (line 208 of modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php).
Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateInstance('baldwin_us_west_2', Array, Array) (Line: 295)
_batch_process() (Line: 947)
batch_process() (Line: 2149)
Drupal\aws_cloud\Service\Ec2\Ec2Service->runBatch(Object) (Line: 1132)
Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstances() (Line: 691)
aws_cloud_update_ec2_resources(Object) (Line: 106)
Drupal\aws_cloud\Controller\Ec2\ApiController->updateAll()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Notice: Undefined index: SubnetId in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateInstance() (line 209 of modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php).
Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateInstance('baldwin_us_west_2', Array, Array) (Line: 295)
_batch_process() (Line: 947)
batch_process() (Line: 2149)
Drupal\aws_cloud\Service\Ec2\Ec2Service->runBatch(Object) (Line: 1132)
Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstances() (Line: 691)
aws_cloud_update_ec2_resources(Object) (Line: 106)
Drupal\aws_cloud\Controller\Ec2\ApiController->updateAll()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Notice: Undefined index: SourceDestCheck in Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateInstance() (line 210 of modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php).
Drupal\aws_cloud\Service\Ec2\Ec2BatchOperations::updateInstance('baldwin_us_west_2', Array, Array) (Line: 295)
_batch_process() (Line: 947)
batch_process() (Line: 2149)
Drupal\aws_cloud\Service\Ec2\Ec2Service->runBatch(Object) (Line: 1132)
Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstances() (Line: 691)
aws_cloud_update_ec2_resources(Object) (Line: 106)
Drupal\aws_cloud\Controller\Ec2\ApiController->updateAll()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

@jigish. This patch looks good now.

@yas, can you please do a review using your EC2 account to make sure my EC2 account didn't miss anything during the create process?

@baldwinlouie

Thank you for your review. I tested the patch on my local testing env and looks good to me now. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.