t() calls should be avoided in classes, use dependency injection and $this->t() instead in view ui module

Looks fine.

There's usages of t() in

• core/modules/views_ui/src/ViewAddForm.php
• core/modules/views_ui/src/Form/Ajax/EditDetails.php
• core/modules/views_ui/src/Form/Ajax/Rearrange.php
• core/modules/views_ui/src/Form/Ajax/RearrangeFilter.php
• core/modules/views_ui/src/Form/Ajax/ReorderDisplays.php

that can be converted to $this->t().

The usage in core/modules/views_ui/src/ViewUI.php can't be changed because this class is not injectable with services atm.

Also I suspect there is a meta issue for fixing all the usages of t() where appropriate that this should linked to and checked that it is following the scope agreed on that issue.

Looks fine for me.

Created Meta issue as #5 suggested

Also fixed CS and replaced usage in core/modules/views_ui/src/ViewUI.php

Thanks for working on this.

In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Reference: https://www.drupal.org/core/scope#files

In particular, t() calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion. So, closing as a duplicate of the parent issue in #3113904: [META] Replace t() calls inside of classes .

Thanks!