Using GET to update facet blocks can help the server to return cacheable responses and thus reduce the server load.

CommentFileSizeAuthor
#9 facets-update_facets_get-3046872-16-8.patch5.47 KBnamisha jadhav
#8 facets-update_facets_get-3046872-16-7.patch5.85 KBanand.toshniwal93
#7 facets-update_facets_get-3046872-16.patch5.81 KBrakshith.thotada
#6 interdiff_5-6.txt627 bytesid.aleks
#6 facets-update_facets_get-3107826-6.patch5.68 KBid.aleks
#5 facets-update_facets_get-3107826-5.patch5.42 KBmaximpodorov
#4 facets-update_facets_get-3107826-4.patch5.36 KBmaximpodorov
#3 facets-update_facets_get-3107826-3.patch4.42 KBmaximpodorov
#2 facets-update_facets_get-3107826-2.patch3.39 KBmaximpodorov

Comments

maximpodorov created an issue. See original summary.

maximpodorov’s picture

maximpodorov commented
Status: Active » Needs review
StatusFileSize
new facets-update_facets_get-3107826-2.patch3.39 KB

The JS code is taken from https://www.drupal.org/project/views_ajax_get module.

maximpodorov’s picture

maximpodorov commented
StatusFileSize
new facets-update_facets_get-3107826-3.patch4.42 KB

The CacheableAjaxResponse class is added.

maximpodorov’s picture

maximpodorov commented
StatusFileSize
new facets-update_facets_get-3107826-4.patch5.36 KB

Block cacheable metadata are added to the response.

maximpodorov’s picture

maximpodorov commented
StatusFileSize
new facets-update_facets_get-3107826-5.patch5.42 KB

More block cacheable metadata are added to the response.

id.aleks’s picture

id.aleks commented
StatusFileSize
new facets-update_facets_get-3107826-6.patch5.68 KB
new interdiff_5-6.txt627 bytes

Hello Maxim. Thanks for your work.

We have faced the issue when using the approach from https://www.drupal.org/project/views_ajax_get module. The js code form the mentioned module doens't incude drupalSettings.ajaxPageState.theme and drupalSettings.ajaxPageState.theme_token that may cause incorrect behaviour during the render proccess.

options.data['ajax_page_state[libraries]'] = drupalSettings.ajaxPageState.libraries; has been added to prevent returning already loaded files. See docroot/core/misc/ajax.es6.js

See Rendering does not use correct nondefault theme for anonymous (2938055)

rakshith.thotada’s picture

rakshith.thotada commented
StatusFileSize
new facets-update_facets_get-3046872-16.patch5.81 KB

Rerolling the patch for the issue https://www.drupal.org/project/facets/issues/3046872 with fix

anand.toshniwal93’s picture

anand.toshniwal93 commented
StatusFileSize
new facets-update_facets_get-3046872-16-7.patch5.85 KB

Re-rolling patch from comment 7 against 2.0.6

namisha jadhav’s picture

namisha jadhav commented
StatusFileSize
new facets-update_facets_get-3046872-16-8.patch5.47 KB

Re-rolling patch from comment 8 against 2.0.9