The Panels test suite is a mess, and is using a lot of deprecated base classes from SimpleTest. Let's unify it here and make all the tests PHPUnit tests.

CommentFileSizeAuthor
#5 3107784-5.patch7.81 KBphenaproxima
#4 3107784-4.patch7.25 KBphenaproxima
#3 3107784-3.patch6.88 KBphenaproxima
#2 3107784-2.patch6.38 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 3107784-2.patch6.38 KB

Let's see how this does.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3107784-3.patch6.88 KB

This should both convert the tests to PHPUnit, and in the process, fix the broken ones. I don't know my way around run-tests.sh well enough to bother fixing things as they are in HEAD.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3107784-4.patch7.25 KB

D'oh, missed a spot with a namespace.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3107784-5.patch7.81 KB

Let's see if this one behaves itself.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thanks @phenaproxima, I've committed the test changes to -dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.