The above patch works fine...
Note: There are some coding standards that still need to be fixed.

CommentFileSizeAuthor
#6 interdiff-3107618-2-6.txt231 byteshardik_patel_12
#6 3107618-6.patch1.36 KBhardik_patel_12
#2 3107618-2.patch1.33 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3107618-2.patch1.33 KB
hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3107618-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented
Title: Remove Unused $block_storage variable from views ui test files » Remove Unused variables from views ui test files
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3107618-6.patch1.36 KB
new interdiff-3107618-2-6.txt231 bytes

Kindly review a new patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Closed (duplicate)

See #3106216-11: Remove unused variables from core. We should be implementing a PHPCS rule and fixing this once and forever.