Problem/Motivation

The DbDumpCommand command hard codes the version to '8.0'. This means that dumps created with it have the wrong version string.

Proposed resolution

Use \Drupal::VERSION instead.

Remaining tasks

User interface changes

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#11 interdiff_9-11.txt866 bytesravi.shankar
#11 3107472-11.patch2.97 KBravi.shankar
#9 3107472-9.patch2.96 KBkishor_kolekar
#3 3107472-2.patch2.92 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott credited jibran.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Related issues: +#3087644: Remove Drupal 8 updates up to and including 88**
StatusFileSize
new 3107472-2.patch2.92 KB

Crediting @jibran as the originator of this fix in #3087644: Remove Drupal 8 updates up to and including 88**

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Reviewed in the other issue, but much better for this to be split out.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3107472-2.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

Seems like a random fail.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This seems sensible for creating our future dumps. The patch doesn't currently apply on 9.1.x, though, so we need a D9 version.

I waffled on whether it should have a CR; it's a small behavior change for a very internal tool, so I'm leading toward "no".

kishor_kolekar’s picture

kishor_kolekar commented
Status: Needs work » Needs review
StatusFileSize
new 3107472-9.patch2.96 KB

reroll the patch for 9.1
please review the patch.

Status: Needs review » Needs work

The last submitted patch, 9: 3107472-9.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3107472-11.patch2.97 KB
new interdiff_9-11.txt866 bytes

Here this patch might fix failed tests.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Thanks, for the reroll.

  • xjm committed 4276e51 on 9.1.x 
    Issue #3107472 by ravi.shankar, alexpott, kishor_kolekar, jibran:...

  • xjm committed be7e303 on 9.0.x 
    Issue #3107472 by ravi.shankar, alexpott, kishor_kolekar, jibran:...

  • xjm committed f75a4b4 on 8.9.x 
    Issue #3107472 by ravi.shankar, alexpott, kishor_kolekar, jibran:...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed #11 to 9.1.x and 9.0.x, and #3 to 8.9.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.