Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The DbDumpCommand command hard codes the version to '8.0'. This means that dumps created with it have the wrong version string.
Proposed resolution
Use \Drupal::VERSION instead.
Remaining tasks
User interface changes
N/a
API changes
None
Data model changes
None
Release notes snippet
N/a
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff_9-11.txt | 866 bytes | ravi.shankar |
#11 | 3107472-11.patch | 2.97 KB | ravi.shankar |
#9 | 3107472-9.patch | 2.96 KB | kishor_kolekar |
#3 | 3107472-2.patch | 2.92 KB | alexpott |
Comments
Comment #3
alexpottCrediting @jibran as the originator of this fix in #3087644: Remove Drupal 8 updates up to and including 88**
Comment #4
catchReviewed in the other issue, but much better for this to be split out.
Comment #6
jibranSeems like a random fail.
Comment #8
xjmThis seems sensible for creating our future dumps. The patch doesn't currently apply on 9.1.x, though, so we need a D9 version.
I waffled on whether it should have a CR; it's a small behavior change for a very internal tool, so I'm leading toward "no".
Comment #9
kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commentedreroll the patch for 9.1
please review the patch.
Comment #11
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedHere this patch might fix failed tests.
Comment #12
jibranThanks, for the reroll.
Comment #16
xjmCommitted #11 to 9.1.x and 9.0.x, and #3 to 8.9.x. Thanks!