Problem/Motivation

Add object that uses the FactoryInterface should have dependencies inject via ::create and not ::__construct(). This allows parent classes to change their constructor without breaking any code.
@see https://events.drupal.org/seattle2019/sessions/drupal-9-coming-getting-y...

Example: \Drupal\config_sync\Controller\ConfigSyncController::create
@see https://www.youtube.com/watch?time_continue=1554&v=hN9KjaBvAUk
@see https://www.previousnext.com.au/blog/safely-extending-drupal-8-plugin-cl...

Proposed resolution

Fix subclassing and stop overriding constructors.

CommentFileSizeAuthor
#3 advagg-Fix_subclassing_and_stop_overriding_constructors_in_advagg_mod_Form_SettingsForm-3107175-3-D8.patch1.73 KBthalles
#2 advagg-Fix_tests_that_broken_with_changes_in_advagg_mod_Form_SettingsForm-3107192-2-D8.patch1.73 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new advagg-Fix_tests_that_broken_with_changes_in_advagg_mod_Form_SettingsForm-3107192-2-D8.patch1.73 KB

Follow a patch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new advagg-Fix_subclassing_and_stop_overriding_constructors_in_advagg_mod_Form_SettingsForm-3107175-3-D8.patch1.73 KB

the patch #2 have wrong name, follow a new patch

  • thalles committed 9a78a47 on 8.x-4.x 
    Issue #3107192 by thalles: Fix subclassing and stop overriding...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.