CommentFileSizeAuthor
#2 3106993-2.patch2.06 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3106993-2.patch2.06 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Status: Needs review » Reviewed & tested by the community

#2 works fine. applied successfully.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3107003: \Drupal calls should be avoided in classes, use dependency injection instead in core/modules/update/src/Form classes

@Hardik_Patel_12 thanks for filing this patch. Fixing dependency inject on a class by class basis is going to be quite painful. Please read https://www.drupal.org/core/scope - I think a good scope here would be to combine this with #3107003: \Drupal calls should be avoided in classes, use dependency injection instead in core/modules/update/src/Form classes and do all the injection necessary in core/modules/update/src/Form - there are three forms to update there.

So I'm going to close this as a duplicate of #3107003: \Drupal calls should be avoided in classes, use dependency injection instead in core/modules/update/src/Form classes as that has further instructions on how to do this and respect our BC promise.

hardik_patel_12’s picture

hardik_patel_12 commented

@alexpott , I got your point .Thankyou.