CommentFileSizeAuthor
#2 3106465-2.patch3.43 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

StatusFileSize
new3.43 KB

Kindly apply a new patch.

hardik_patel_12’s picture

Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
naresh_bavaskar’s picture

Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

Assigned: naresh_bavaskar » Unassigned
Status: Needs review » Reviewed & tested by the community

The above patch looks fine.

alexpott’s picture

Status: Reviewed & tested by the community » Closed (won't fix)
  1. +++ b/core/modules/system/system.post_update.php
    @@ -251,7 +251,7 @@ function system_post_update_entity_reference_autocomplete_match_limit(&$sandbox
    -    foreach ($display->getComponents() as $field_name => $component) {
    +    foreach ($display->getComponents() as $component) {
    

    As per this is not an unused variable. See #3105981-11: Remove unused variable from view.module for ideas on further work about unused variables.

  2. +++ b/core/modules/system/system.post_update.php
    --- a/core/modules/system/tests/src/Functional/Update/PageTitleConvertedIntoBlockUpdateTest.php
    +++ b/core/modules/system/tests/src/Functional/Update/PageTitleConvertedIntoBlockUpdateTest.php
    
    +++ b/core/modules/system/tests/src/Functional/Update/PageTitleConvertedIntoBlockUpdateTest.php
    --- a/core/modules/system/tests/src/Functional/Update/SevenSecondaryLocalTasksConvertedIntoBlockUpdateTest.php
    +++ b/core/modules/system/tests/src/Functional/Update/SevenSecondaryLocalTasksConvertedIntoBlockUpdateTest.php
    
    +++ b/core/modules/system/tests/src/Functional/Update/SevenSecondaryLocalTasksConvertedIntoBlockUpdateTest.php
    --- a/core/modules/system/tests/src/Functional/Update/SiteBrandingConvertedIntoBlockUpdateTest.php
    +++ b/core/modules/system/tests/src/Functional/Update/SiteBrandingConvertedIntoBlockUpdateTest.php
    

    These are all being removed as part of #3087644: Remove Drupal 8 updates up to and including 88**

The above two points mean this issue is closed - won't fix - but @Hardik_Patel_12 note the advice in #3105981-11: Remove unused variable from view.module if you want to work on removing unused variables from core.