The Yahoo Directory was closed in 2014 so there's no point in having the NOYDIR option available for the ROBOTS tag.

CommentFileSizeAuthor
#16 metatag-n3106383-16.patch10.04 KBdamienmckenna
#16 metatag-n3106383-16.interdiff.txt698 bytesdamienmckenna
#14 metatag-n3106383-14.patch10.72 KBdamienmckenna
#14 metatag-n3106383-14.interdiff.txt1.31 KBdamienmckenna
#12 metatag-n3106383-12.patch10.57 KBdamienmckenna
#10 metatag-n3106383-10.patch10.58 KBdamienmckenna
#8 remove-noydir-option-on-robots-tag-3106383-8.patch10.63 KBfathima.asmat
#6 remove-noydir-option-on-robots-tag-3106383-6.patch9.98 KBfathima.asmat
#3 remove-noydir-option-on-robots-tag-3106383-3.patch3.59 KBfathima.asmat

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new remove-noydir-option-on-robots-tag-3106383-3.patch3.59 KB

I agree with Damien's suggestion. The patch attached gets rid of the usage of NOYDIR from the meta tag module.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Thank you for that!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

I think it needs update scripts to remove the value from existing configuration, and remove it from entity field values.

fathima.asmat’s picture

fathima.asmat commented
Version: 8.x-1.x-dev » 8.x-1.22
Status: Needs work » Needs review
StatusFileSize
new remove-noydir-option-on-robots-tag-3106383-6.patch9.98 KB

The earlier patch is rerolled for version 8.x-1.22 and update hook added for removing existing data with 'noydir'.

Status: Needs review » Needs work

The last submitted patch, 6: remove-noydir-option-on-robots-tag-3106383-6.patch, failed testing. View results

fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new remove-noydir-option-on-robots-tag-3106383-8.patch10.63 KB

Trying to fix the unserialize D6 issue from the test fails ...

fathima.asmat’s picture

fathima.asmat commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.22 » 8.x-1.x-dev
Parent issue: » #3360505: Plan for Metatag 8.x-1.24
StatusFileSize
new metatag-n3106383-10.patch10.58 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n3106383-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3106383-12.patch10.57 KB

Doh, accidentally included some changes for v2.

Status: Needs review » Needs work

The last submitted patch, 12: metatag-n3106383-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3106383-14.interdiff.txt1.31 KB
new metatag-n3106383-14.patch10.72 KB

I think this should fix the last test failure.

Status: Needs review » Needs work

The last submitted patch, 14: metatag-n3106383-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3106383-16.interdiff.txt698 bytes
new metatag-n3106383-16.patch10.04 KB

It turned out that the earlier test change was incorrect.

This should work now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you.

  • DamienMcKenna committed 8e747a44 on 2.0.x 
    Issue #3106383 by DamienMcKenna: Follow-up to fix tests for removed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.