CommentFileSizeAuthor
#2 3106290-2.patch14.53 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3106290-2.patch14.53 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

These are all test case modules, I don't think this is worth fixing.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.0.x-dev » 8.8.x-dev

Right, we actually have a policy against using t() unnecessarily in tests, and this is often applied to their fixtures as well. The one case for adding these t() would be if we had a phpcs rule that was checking for the translation call. Is there such a coder rule? If not, the issue can be closed wontfix.

This also isn't a major-only issue nor specific to 9.0.x, so moving to the bugfix branch (which would be the backport target for a test cleanup if it were actually committed). (If it were to add t() to non-test strings, that would be minor-only and therefore filed against 9.1.x-dev instead.)

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Status: Needs review » Postponed (maintainer needs more info)

Postponing for info on whether or not there's some phpcs rule flagging this.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

@xjm to my knowledge we still don't have a check for t() being used in tests. Think it's been up to the reviewer and committer to make sure those get in.