CommentFileSizeAuthor
#11 interdiff.txt952 bytespratik_kamble
#11 3106272-11.patch594 bytespratik_kamble
#2 3106272-2.patch1.9 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3106272-2.patch1.9 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
hardik_patel_12’s picture

hardik_patel_12 commented
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented 
+++ b/core/modules/system/src/Tests/Update/UpdatePathTestBase.php
@@ -299,7 +299,7 @@ protected function runUpdates() {
         foreach (\Drupal::entityDefinitionUpdateManager()
-          ->getChangeSummary() as $entity_type_id => $summary) {
+          ->getChangeSummary() as $summary) {

Now this is shorter it might be more readable if it were all on one line?

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs review » Reviewed & tested by the community

above patch looks fine. @hardik_patel

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

We often keep keys in foreach statements for readability even if they're not used. Let's remove those from the patch and open a coding standards issue to discuss.

Rangaswini’s picture

Rangaswini commented
Assigned: Unassigned » Rangaswini
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: Rangaswini » pratik_kamble
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
StatusFileSize
new 3106272-11.patch594 bytes
new interdiff.txt952 bytes

Rerolled patch to keep the key in foreach.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Needs work » Needs review
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: pratik_kamble » Unassigned
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Remove unused variables from multiple file » Remove unused variable from DateFormatFormBase
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

  • catch committed d33f375 on 9.0.x 
    Issue #3106272 by pratik_kamble, Hardik_Patel_12, longwave,...

  • catch committed d8d90eb on 8.9.x 
    Issue #3106272 by pratik_kamble, Hardik_Patel_12, longwave,...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.0.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed d33f375 and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.