Move HTML classes from claro_preprocess_textarea to a template

I have tested the patch and looks good to be merged.
The classes are being added from textarea.hrml.twig file.

Adding the screenshot below the. The classes are being highlighted which are in the textarea.html.twig file.

+++ b/core/themes/claro/templates/form/textarea.html.twig
@@ -0,0 +1,25 @@
+<div{{ wrapper_attributes }}>
+  <textarea{{ attributes.addClass(classes) }}>{{ value }}</textarea>

It seems like this template is removing some classes from the templates. For example form-textarea-wrapper class is now missing which is used by Claro.

@Hardik_Patel_12 based on your patch the screenshot has been taken on Seven theme. This change is in Claro.

Did you check if we should keep any of the classes that already exist in Classy textarea.html.twig?

I've re-rolled patch for 9.1

please avoid #17
re-rolled patch for 9.1

Hi @kishor_kolekar thanks for the patch #19
It working as expected.

It seems like Claro depends on those classes because there is some CSS attached to them, at least in Stable/core. Let's make sure that the CSS classes from core/themes/classy/templates/form/textarea.html.twig are included in the new template, and that core/themes/classy/templates/form/textarea.html.twig gets removed.

Hi @lauriii,
I've added those classed from core/themes/classy/templates/form/textarea.html.twig into new template and removed it from classy section.
Please review this patch.

Verified and tested by applying the patch #29.It looks good to me.Can be moved to RTBC. RTBC +1.

Before Patch -

After Patch -

This requires a post update hook because we are moving a template. It doesn't seem like there's one in Drupal 9.1.x yet, so we should add one here to make sure that people can upgrade to 9.1.x without getting errors.

Implementing the ask in #34, Please review. The patch is made by taking latest changes from the branch.

The patch in #38 doesn't include the new template.

@laurii, this is because the latest pull already had those changes. Therefore they didn’t show up when i created the patch.

@himanshu_sindhwani I cannot see core/themes/claro/templates/form/textarea.html.twig in the code base at least on the 9.1.x branch. Did you by any chance compare against a local development branch?

Yes, I see it was due to some issues in my local branch. Thanks for the review @laurii.
I have updated the patch with a template file missing in #38. Please check.

Correcting the failure in #43.

The changes to claro.theme and the template look good, just spotted one thing:

+++ b/core/modules/system/system.post_update.php
@@ -168,3 +168,11 @@ function system_post_update_schema_version_int() {
+function system_post_update_remove_claro_preprocess() {
+  // Empty post-update hook.
+}

A recently committed issue added system_post_update_claro_dropbutton_variants() to 9.1, so this empty post-update hook is no longer needed.

Since removing the post_update hook implementation is fairly straightforward, I'm providing a patch and an RTBC.

Committed 4b052b5 and pushed to 9.1.x. Thanks!