CommentFileSizeAuthor
#2 type_hinting_missing-3104538-2.patch626 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Active » Needs review
StatusFileSize
new type_hinting_missing-3104538-2.patch626 bytes

Kindly review a new patch

hardik_patel_12’s picture

hardik_patel_12 commented

Type hint "\Drupal\Core\Session\AccountInterface" missing for $account in _user_mail_notify() function

hash6’s picture

hash6 commented
Assigned: Unassigned » hash6
hash6’s picture

hash6 commented
Assigned: hash6 » Unassigned
Status: Needs review » Reviewed & tested by the community

Tested it on Drupal core and it does not report any issue while sending a mail notification to the user.
Thanks @Hardik_Patel_12

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: type_hinting_missing-3104538-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented

The failing test isn't related to this patch.

Drupal\BuildTests\Framework\Tests\BuildTestTest::testPortMany
RuntimeException: Unable to start the web server.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Reviewed & tested by the community

Back to RTBC as per comment #5 and #7

  • catch committed baf8e01 on 9.0.x 
    Issue #3104538 by Hardik_Patel_12, Harshal Pradhan, ravi.shankar: Type...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.0.x and 8.9.x, thanks!

  • catch committed 015cd05 on 8.9.x 
    Issue #3104538 by Hardik_Patel_12, Harshal Pradhan, ravi.shankar: Type...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.