CommentFileSizeAuthor
#2 expected_type_hint-3104534-2.patch814 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new expected_type_hint-3104534-2.patch814 bytes

Kindly follow a new patch

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
hardik_patel_12’s picture

hardik_patel_12 commented
Component: documentation » system.module
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs review » Reviewed & tested by the community

The above patch looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: expected_type_hint-3104534-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented

The failing test isn't related to this patch.

Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest::testArticleNode
Field node/1/body/en/full did not match its expectation selector (.cke_editable_inline), actual HTML: Hello world!I do not know what to say…I wish I were eloquent.
Failed asserting that 'Hello world!I do not know what to say…I wish I were eloquent.' is identical to true.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

  • catch committed ffbc5de on 9.0.x 
    Issue #3104534 by Hardik_Patel_12: Expected type hint "GetResponseEvent...

  • catch committed 4170d69 on 8.9.x 
    Issue #3104534 by Hardik_Patel_12: Expected type hint "GetResponseEvent...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.0.x and backported to 8.9.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.