Problem/Motivation

The Drupal\field_group\Form\FieldGroupAddForm use the static method \Drupal::request()

Proposed resolution

Replace use of static method \Drupal::request() by inherited service requestStack

CommentFileSizeAuthor
#2 field_group-Replace_use_of_static_method_Drupal_request_by_inherited_service_requestStack-3103734-2-D8.patch670 bytesthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new field_group-Replace_use_of_static_method_Drupal_request_by_inherited_service_requestStack-3103734-2-D8.patch670 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

You need to use $this->getRequest(), the propery is set on-demand.

  • nils.destoop committed af386b2 on 8.x-3.x authored by thalles 
    Issue #3103734 by thalles, Berdir: Replace use of static method \Drupal...
nils.destoop’s picture

nils.destoop commented
Status: Needs work » Fixed

Thx for noticing. I committed the fix, but replaced it with the getRequest method.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.