Problem/Motivation

The off-canvas dialog can be rendered either at the "top" or the "side".
There is a small draggable handle at the top left of the side dialog for resizing the dialog width.

This handle is always on the left, even when the dialog opens from the left in a RTL language.
This handle is also present in the "top" off-canvas dialog even though scaling width is not desirable and the handle is not clickable.

Proposed resolution

Check language direction and change the dialog option for the resizable handle position.
Remove the handle entirely if the off-canvas dialog is opened from the top.

CommentFileSizeAuthor
#19 interdiff-17_19.txt1.51 KBgauravvvv
#19 3102865-19.patch1.17 KBgauravvvv
#17 interdiff-15_17.txt744 bytesgauravvvv
#17 3102865-17.patch2.67 KBgauravvvv
#15 interdiff-13_15.txt746 bytesgauravvvv
#15 3102865-15.patch2.29 KBgauravvvv
#13 3102865-13.patch2.29 KBgauravvvv
#2 3102865-2.patch1.26 KBzrpnr

Comments

zrpnr created an issue. See original summary.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
StatusFileSize
new 3102865-2.patch1.26 KB

This patch sets dialogOptions['resizable'] to either 'e' for RTL or 'w' for LTR, and FALSE if position is not "side".
The styling for .ui-resizable-e was already present in core/assets/vendor/jquery.ui/themes/base/dialog.css.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3102865-2.patch, failed testing. View results

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bwaindwain’s picture

bwaindwain commented

Patch #2 works good for us. +1

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3102865-13.patch2.29 KB

Patch #2, no longer applies to d11. I have attached a patch for D11.

Status: Needs review » Needs work

The last submitted patch, 13: 3102865-13.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3102865-15.patch2.29 KB
new interdiff-13_15.txt746 bytes

Fixed test failures, Attached interdiff for same.

Status: Needs review » Needs work

The last submitted patch, 15: 3102865-15.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3102865-17.patch2.67 KB
new interdiff-15_17.txt744 bytes

Tried fixing test errors. Attached interdiff for same.

Status: Needs review » Needs work

The last submitted patch, 17: 3102865-17.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3102865-19.patch1.17 KB
new interdiff-17_19.txt1.51 KB

Removed unused files

Status: Needs review » Needs work

The last submitted patch, 19: 3102865-19.patch, failed testing. View results

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.