Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Dec 2019 at 12:44 UTC
Updated:
16 Jan 2020 at 15:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shubham.prakash commentedComment #3
jonathan1055 commentedI was about to start this myself, so thank you for the patch.
In AssertLegacyTrait.php it says:
Given that we have #3050086: Replace deprecated function assertText() with pageTextContains() I'd like to replace assertNoText() with pageTextNotContains() to keep it consistent. Also this is html so we should be using pageTextNotContains() for html responses.
Secondly, the additional parameter in all the assert calls should be removed in the replacement. Sometimes this gives good information about what we are testing, so in these cases the text could become a comment immediately preceding the assert. Other times the existing general comment is adequate so the second parameter can just be deleted.
Comment #4
shubham.prakash commentedHere is the patch as asked for.
Comment #5
shubham.prakash commentedSorry for the last patch. This patch would fix the issue.
Comment #6
shubham.prakash commentedLast patch failed due to changes in latest commit. Here is the patch again.
Comment #7
shubham.prakash commentedMissed to replace at 2 places .
Comment #9
jonathan1055 commentedThanks for the updated patch. I also changed
$this->assertSession()to$assertwhere it was available, and added it for the tests that had lots of uses. I fixed the two coding standards errors too.Committed and fixed.