As per the discussion in #3061341: provide support for Smart Date add a plugin to allow the 8.x-3.x branch of Fullcalendar View to properly display Smart Date values.

CommentFileSizeAuthor
#3 smart_date-provide_fullcalendarviewprocessor_plugin_to_support_fullcalendar_view-3101524-003.patch3.39 KBstefan.korn
#2 smart_date-fullcalendar_view-plugin-3101524-2.patch5.88 KBmandclu

Comments

mandclu created an issue. See original summary.

mandclu’s picture

mandclu commented
Status: Active » Needs review
StatusFileSize
new smart_date-fullcalendar_view-plugin-3101524-2.patch5.88 KB

Rolled the code written by @Mingsong at #3061341: provide support for Smart Date into a patch.

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
StatusFileSize
new smart_date-provide_fullcalendarviewprocessor_plugin_to_support_fullcalendar_view-3101524-003.patch3.39 KB

I was digging a little bit into this and the patch did not work.

I have done a rewrite of the patch, which works for me in displaying smart date dates correctly in a view with FullCalendar format.

First of all #3110553: Allow FullcalendarViewProcessor plugins to define supported field types is needed to make it work.

It's working with recurring smart dates too.

As an assumption for recurring smart dates and smart date fields which are allowing multiple values this patch requires the setting
"Display all values in the same row" in the view to be not checked. Imho this is reasonable and be a thought of as a requirement.

FullCalendar View is providing a recurring events feature with a submodule of its own. I did not take this into account, since smart date is offering recuring dates by itself imho a better way. So the FullCalendar View submodule for recurring events should not be used together with smart date.

FullCalendar View is also providing drag and drop editing of events. This is currently not working with smart date. This would be a further ToDo.

I have not yet worked on timezone handling.

michaelschutz’s picture

michaelschutz commented

Thanks to both of you for this work on moving things forward. I've just tested it with the patch from #3 (and the linked one from #3110553), and it works fine for me too.

I'm super excited about using Smart Date as a full-fledged replacement for core DateTime - especially now with recurring dates. (mandclu, I'm glad you went with a Smart Date-centric solution instead of relying on FCV's implementation. Much more intuitive, and much more flexible for use outside of FCV too!)

Thanks again - I can't contribute code, but can help in testing and documentation as needed.

mandclu’s picture

mandclu commented
Status: Needs review » Fixed

@stefan.korn your work on this is greatly appreciated, including the patch for fullcalendar_view.

@michaelschutz thanks for testing and providing feedback. In future feel free to move the issue to RTBC.

This has been merged in, excited to have this in the next release!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.