I noticed that an error was produced while checking for coding standard violations:
phpcs --standard=Drupal .
FILE: /var/www/html/drupal2/modules/custom/social_auth_google/src/Plugin/Network/GoogleAuth.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
37 | ERROR | [x] Data types in @throws tags need to be fully namespaced
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------
Time: 171ms; Memory: 8MB
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | social_auth_google-fix-coding-standards-3101054-6.patch | 2.11 KB | neel24 |
| #5 | social_auth_google-fix-coding-standards-3101054-5.patch | 2.17 KB | neel24 |
| #2 | social_auth_google-fix-coding-standards-3101054-2.patch | 559 bytes | neel24 |
Comments
Comment #2
neel24 commentedI've created a patch which fixes the error.
Comment #4
gvsoComment #5
neel24 commentedSorry, I had not fixed the DrupalPractice error as well. I'm attaching a new patch for this.
Comment #6
neel24 commentedSorry, had forgotten to remove
var_dump. Attaching new patch.Comment #8
gvsoThanks!