I noticed that an error was produced while checking for coding standard violations:

phpcs --standard=Drupal .

FILE: /var/www/html/drupal2/modules/custom/social_auth_google/src/Plugin/Network/GoogleAuth.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 37 | ERROR | [x] Data types in @throws tags need to be fully namespaced
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

Time: 171ms; Memory: 8MB

Comments

neel24 created an issue. See original summary.

neel24’s picture

Status: Active » Needs review
StatusFileSize
new559 bytes

I've created a patch which fixes the error.

  • gvso committed 54ccd58 on 8.x-2.x
    Issue #3101054 by neel24: Fix coding standards
    
gvso’s picture

Status: Needs review » Fixed
neel24’s picture

Status: Fixed » Needs review
StatusFileSize
new2.17 KB

Sorry, I had not fixed the DrupalPractice error as well. I'm attaching a new patch for this.

neel24’s picture

Sorry, had forgotten to remove var_dump. Attaching new patch.

  • gvso committed 867c132 on 8.x-2.x
    Issue #3101054 by neel24: Fix coding standards
    
gvso’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.