Closed (fixed)
Project:
Group
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2019 at 02:12 UTC
Updated:
3 Jan 2020 at 15:04 UTC
Jump to comment: Most recent
Folks keep getting nailed by #3061353: Replace deprecated EntityManager and add EntityFieldManager in GroupContentViewsData
E.g. @see #3095390: Drupal Core 8.8-beta1 update fails with Group 8.x-1.0-rc4
It's been a while since RC4, and a lot of goodness is already in the 8.x-1.x branch.
Ship a 8.x-1.0-rc5 release.
TBD.
Comments
Comment #2
dwwNote: someone called #3068918: 8.8.x: PHP Fatal error: Uncaught Error: Call to a member function getBaseFieldDefinitions() on null - related to GroupContentViewsData.php related to this, but that should *not* be included in this release.
Comment #3
kristiaanvandeneyndeI want to land the permission calculator changes that I've been working on and then cut a new release. Might be able to pull that off this week.
Comment #4
heddnIs there a link to the issue for #3?
Comment #5
kristiaanvandeneynde#3099331: Make sure the permission calculator works for non-current-user accounts
Code is here (I fixed it locally already): #3079463: Adding a user to a group does not invalidate his permission cache
Comment #6
catchWhile we're here #2752603: Request Membership feature is still listed on the stable release roadmap as a child issue - is that likely to go into a future rc or after 8.x-1.0 at this point?
Comment #7
maseyuk commentedNot sure if this is helpful but I went from rc4 to the latest dev as of today and it caused an issue with authenticated users viewing the entities
My setup is fairly simple where "member" could edit the nodes in a group (only ticked "Entity: Edit any content entities" for "member"). But everyone could view the entities ("Entity: View content entities" ticked for anon, outsider, member)
E.g.
Group 1:
User A
Node A
Group 2:
User B
Node B
Before the update User A could edit Node A and view Node B. But after the update User A could only view Node A and no longer view Node B
Interestingly anonymous users could still view all nodes regardless of group and it only effected authenticated users.
I tried unticking/reticking the same permissions, rebuilding the permissions/flushing caches but nothing seemed to work. Whatever access checks that were introduced between rc4 and the latest dev seemed to have caused this. Even a simple EntityQuery would only bring back the nodes that User A either is in the same group or nodes that aren't in any group at all
So potentially if you create an rc5 based on the current dev this issue might arise
Comment #8
kristiaanvandeneynde@catch The goal is to have a 1.0 without membership requests and other highly demanded features and make a 1.1, 1.2, etc. release every time we land one of them. This way we don't delay a "stable release" any more than we have to and can have focused "feature releases" soon after.
@maseyuk Nice find, let me see if I can reproduce this.
Comment #9
mxr576Can this be fixed as well in the next stable release?
Comment #10
kristiaanvandeneyndeYes, it seems it is fixed already!
Comment #11
kristiaanvandeneyndehttps://www.drupal.org/project/group/releases/8.x-1.0-rc5