Problem/Motivation

drupal-check easy_breadcrumb  
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------- 
  Line   src/EasyBreadcrumbBuilder.php                                                      
 ------ ----------------------------------------------------------------------------------- 
  348    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:  
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                              
         mb_strtolower() instead.                                                           
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/EasyBreadcrumbBuilderTest.php                                     
 ------ ----------------------------------------------------------------------------------- 
  103    Call to deprecated method assertInternalType() of class PHPUnit\Framework\Assert:  
         https://github.com/sebastianbergmann/phpunit/issues/3369                           
 ------ ----------------------------------------------------------------------------------- 
                                                                                   
 [ERROR] Found 2 errors

Thank's

CommentFileSizeAuthor
#2 easy_breadcrumb-d9_readiness-3100906-2.patch1.04 KBjhuhta

Comments

gmangones created an issue. See original summary.

jhuhta’s picture

jhuhta commented
Status: Needs work » Needs review
StatusFileSize
new easy_breadcrumb-d9_readiness-3100906-2.patch1.04 KB

Fixed the former issue and added core_version_requirement.

I didn't touch the test, as seeing that deprecation and the replacement function (assertIsString) would have required phpunit 8, but Drupal uses ^6.5 || ^7 in D9 still, if I got it right.

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Makes sense

Following the documentation

  • RenatoG committed d83a646 on 8.x-1.x authored by jhuhta 
    Issue #3100906 by jhuhta, gmangones, RenatoG: Drupal 9 Deprecated Code...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Committed to the dev branch.

Thank you so much.

Best,

gmangones’s picture

gmangones commented

Thank everybody.

Have a nice day.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.