Usage of base URL should be avoided and not hardcoded in URI with parameters.

CommentFileSizeAuthor
#5 3100827-5-switch-uri-form-destination.patch.patch1005 bytessiegrist
#2 3100827-2-switch-uri-form-destination.patch1015 bytesgrahl

Comments

grahl created an issue. See original summary.

grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Active » Needs review
StatusFileSize
new 3100827-2-switch-uri-form-destination.patch1015 bytes
gcb’s picture

gcb
he/him
Location Portland, OR
commented
Component: General » Signup Module
Assigned: Unassigned » Pastenes
Pastenes’s picture

Pastenes commented
Assigned: Pastenes » Unassigned
Status: Needs review » Needs work

The patch is causing a test to fail that needs more work.
https://www.drupal.org/pift-ci-job/1506828

It looks like it's line 76 of MailchimpSignupFormTest.php.

siegrist’s picture

siegrist
Primary language German
commented
StatusFileSize
new 3100827-5-switch-uri-form-destination.patch.patch1005 bytes

Reroll patch.

gcb’s picture

gcb
he/him
Location Portland, OR
commented
Assigned: Unassigned » spncr
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 3100827-5-switch-uri-form-destination.patch.patch, failed testing. View results

  • spncr committed 86a8f06 on 2.x authored by Siegrist 
    Issue #3100827 by grahl, Siegrist: Destination does not support...
spncr’s picture

spncr commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs work » Fixed

This patch has been committed to 2.x-dev and will be included in the next release 2.x release. Thank you for your contributions!

The test mentioned in #4 is now passing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.