Add Access control option to show/hide unpublished entities

CommentFileSizeAuthor
#16 verf-add-access-control-3100599-16.patch1.84 KBsvendecabooter
#11 verf-add-access-control-3100599-11.patch1.73 KBmrshowerman
#8 add-access-control-adjusted-casper.patch2.15 KBcaspervoogt
#7 add-access-control-adjusted-casper.patch2.26 KBcaspervoogt
#5 add-access-control-adjusted.patch5.89 KBcaspervoogt
#2 remove_restricted_access_label-3100599-2.patch710 bytesKakarotu
add-access-control.patch6.01 KBKakarotu

Issue fork verf-3100599

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ibra_ahmad_4 created an issue. See original summary.

Kakarotu’s picture

Kakarotu commented
Title: Unpublished Entities appears for anonymous users » Unpublished content should show nothing in options instead of showing "Restricted Access"
Version: 8.x-1.0-beta7 » 8.x-1.x-dev
Priority: Critical » Normal
Status: Patch (to be ported) » Active
StatusFileSize
new remove_restricted_access_label-3100599-2.patch710 bytes

Sorry. I downloaded an older version, The problem has been solved in the latest version. but it needs to remove the label "Restricted access".

yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented
Status: Active » Reviewed & tested by the community

Working great on our website.

caspervoogt’s picture

caspervoogt commented

I have an issue with unpublished nodes showing up (with their node titles) in my view's exposed VERF filter options. I do not see "Restricted Access: instead I just see a mix of published and unpublished node titles. I thought it might be related, but when I tested this patch it didn't solve my issue.

caspervoogt’s picture

caspervoogt commented
StatusFileSize
new add-access-control-adjusted.patch5.89 KB

I just noticed that add-access-control.patch was not applying. It was failing silently in Composer, after telling me it succeeded. The problem is the /public_html/modules/contrib/verf in that file. Ignore my patch; new one coming.

caspervoogt’s picture

caspervoogt commented
caspervoogt’s picture

caspervoogt commented
StatusFileSize
new add-access-control-adjusted-casper.patch2.26 KB

ignore this one

caspervoogt’s picture

caspervoogt commented
StatusFileSize
new add-access-control-adjusted-casper.patch2.15 KB

this one applies cleanly (for me anyway) though it did not solve my particular issue. Maybe it will help someone.

The patch from #2 actually solved my issue.

caspervoogt’s picture

caspervoogt commented
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Reviewed & tested by the community » Needs review
mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new verf-add-access-control-3100599-11.patch1.73 KB

Re-roll of #8.

Status: Needs review » Needs work

The last submitted patch, 11: verf-add-access-control-3100599-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chrisroane’s picture

chrisroane commented

Verified #11 fixes the "Restricted Access" for me on the latest stable release of this module.

sayco’s picture

sayco commented
Status: Needs work » Reviewed & tested by the community

I've also verified that the patch #11 solves the issue!

josebc’s picture

josebc commented
Status: Reviewed & tested by the community » Needs work

shouldn't the label say "Ignore access control" if im not mistaken

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Assigned: Kakarotu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new verf-add-access-control-3100599-16.patch1.84 KB

Updated patch which:

  • Shows the configuration checkbox even for entity types that do not have bundles
  • Improves the label as suggested above

Status: Needs review » Needs work

The last submitted patch, 16: verf-add-access-control-3100599-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

randalv’s picture

randalv commented
Status: Needs work » Reviewed & tested by the community

I've applied the above patch to one of our websites.
After clearing the cache, the issue was solved!

rob230’s picture

rob230 commented

I've also tested #16, it's working.

podarok made their first commit to this issue’s fork.

podarok opened merge request !1

  • podarok committed c26bbc1 on 8.x-1.x 
    Issue #3100599 by caspervoogt, Kakarotu, podarok, svendecabooter:...
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 8.x-1.x-dev » 2.0.0
Status: Fixed » Closed (fixed)

Thanks. Tagged