Problem/Motivation

Run drupal-check reports:

drupal-check autologout
 12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   src/Tests/AutologoutAjaxTest.php                                                                          
 ------ ---------------------------------------------------------------------------------------------------------- 
  14     Class Drupal\autologout\Tests\AutologoutAjaxTest extends deprecated class Drupal\simpletest\WebTestBase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                                
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                               
  41     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:                                 
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                                
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                               
 ------ ---------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------
  Line   src/Tests/AutologoutSessionCleanupOnLoginTest.php                                                                          
 ------ -------------------------------------------------------------------------------------------------------------
  14     Class Drupal\autologout\Tests\AutologoutSessionCleanupOnLoginTest extends deprecated class Drupal\simpletest\WebTestBase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                                                 
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                                                
  35     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:                                                  
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                                                 
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                                                
 ------ -----------------------------------------------------------------------------------------------------------
  Line   src/Tests/AutologoutTest.php                                                                          
 ------ ------------------------------------------------------------------------------------------------------ 
  14     Class Drupal\autologout\Tests\AutologoutTest extends deprecated class Drupal\simpletest\WebTestBase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                            
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                           
  63     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:                             
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,                                            
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.                           
 ------ ------------------------------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 6 errors

Thank's

CommentFileSizeAuthor
#8 interdiff_8-9.txt2.49 KBkbrodej
#8 3100394-8.patch36.79 KBkbrodej
#7 3100394-7.patch36.67 KBbcizej
#3 autologout_d8-3100394-3.patch1.78 KBgmangones

Comments

gmangones created an issue. See original summary.

bcizej’s picture

bcizej commented
Assigned: Unassigned » bcizej
gmangones’s picture

gmangones commented
StatusFileSize
new autologout_d8-3100394-3.patch1.78 KB

Hi, add this patch for review.

Thank's

bcizej’s picture

bcizej commented

Hi gmangones, thanks for patch however it will take more than just renaming classes to get the tests working and passing, I am already working on a patch to convert the tests.

gmangones’s picture

gmangones commented

Thank you @benjamincizej

bcizej’s picture

bcizej commented
Title: Drupal 9 Deprecated Code Report » Drupal 9 Deprecated Code Report (Automated tests)
bcizej’s picture

bcizej commented
Assigned: bcizej » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3100394-7.patch36.67 KB

Added a patch with converted tests.

kbrodej’s picture

kbrodej commented
StatusFileSize
new 3100394-8.patch36.79 KB
new interdiff_8-9.txt2.49 KB

Reviewed patch from #7, found some coding standard issues.

Added a patch which fixes them.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Thanks to all contributors. I tested kbrodej patch and it works as expected.

boshtian’s picture

boshtian commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.