The redirect 404 module adds a new daily count column to its table and the monitoring sensor should use that column instead of the count column.

Comments

arpad.rozsa created an issue. See original summary.

arpad.rozsa’s picture

Status: Active » Needs review
StatusFileSize
new4.78 KB
berdir’s picture

+++ b/config/optional/monitoring.sensor_config.redirect_404.yml
@@ -17,7 +17,7 @@ settings:
   - 'path'
   - 'timestamp'
-  - 'count'
+  - 'daily_count'
   time_interval_field: 'timestamp'

what about show both count and daily count in the verbose fields?

arpad.rozsa’s picture

Added the verbose field and updated the tests.

berdir’s picture

Status: Needs review » Needs work

https://www.drupal.org/project/redirect/releases/8.x-1.5 is out, we can now run tests here. Lets also add a conflicts section to composer.json like drupal core did for pathauto < 1.6, so it's not possible to update monitoring with an old version of the redirect module.

arpad.rozsa’s picture

Status: Needs work » Needs review
StatusFileSize
new5.15 KB
new317 bytes

Added the conflict part to composer.json.

berdir’s picture

Status: Needs review » Fixed

Nice, committed.

  • Berdir committed 109069d on 8.x-1.x authored by arpad.rozsa
    Issue #3100299 by arpad.rozsa: Update redirect 404 sensor to use daily...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.