Problem/Motivation

Several code comments refer to \Drupal\Update\UpdateManager::getProjects(). The correct namespace is \Drupal\update (lower case "update", referring to the Update module).

These comments seem to have been added in #2449809: Remove usage of update_get_projects().

We briefly made the same mistake in a use statement (not a comment) in #3015810: Properly deprecate UPDATE_* constants, but that was promptly corrected.

Proposed resolution

Search for \Drupal\Update and correct the capitalization. You can use the following command to search:

grep -r '\\Drupal\\Update' core

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3100071-2.patch8.11 KBravi.shankar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjifisher created an issue. See original summary.

ravi.shankar’s picture

Here is a patch for this issue please review.

ravi.shankar’s picture

Status: Active » Needs review
dww’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks good.
After applying patch, the codebase is free of references to Drupal\Update.
All changes in the patch are in comments, so bot results are meaningless. ;)

RTBC.

Thanks!
-Derek

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Crediting @benjifisher for creating this issue and @dww for reviewing.

Backporting to 8.8.x as a docs only fix.

Committed and pushed 04e5bbbc98 to 9.0.x and c8c2b9632b to 8.9.x and 32dc816fcc to 8.8.x. Thanks!

  • alexpott committed 04e5bbb on 9.0.x
    Issue #3100071 by ravi.shankar, benjifisher, dww: Several code comments...

  • alexpott committed c8c2b96 on 8.9.x
    Issue #3100071 by ravi.shankar, benjifisher, dww: Several code comments...

  • alexpott committed 32dc816 on 8.8.x
    Issue #3100071 by ravi.shankar, benjifisher, dww: Several code comments...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.