There is no point in having both NPM scripts and Gulp.
Let's keep things in one place and remove Gulp in favor of a few NPM scripts.
This will simplify the workflow and requirements.

CommentFileSizeAuthor
#2 remove_gulp-3100027-2.patch1.05 MBmajmunbog

Comments

majmunbog created an issue. See original summary.

majmunbog’s picture

majmunbog commented
StatusFileSize
new remove_gulp-3100027-2.patch1.05 MB

A huge patch is with the recompiled CSS.
Dependencies are managed with yarn.

Scripts should compile SCSS to CSS, autoprefix the CSS, use nodemon to watch for changes, serve Browsersync with livereload and generate icons in the same manner as before.

majmunbog’s picture

majmunbog commented
Status: Active » Needs review
sumi’s picture

sumi commented

Tested the patch and didn't run into any issues. Node sass, autoprefixer, browsersync are all working as expected, icons are generated and working fine.

sumi’s picture

sumi commented
Status: Needs review » Reviewed & tested by the community

  • majmunbog committed 0196f96 on 8.x-1.x 
    Issue #3100027 by majmunbog: Remove Gulp
majmunbog’s picture

majmunbog commented

Commited, Thanks Sumi.

majmunbog’s picture

majmunbog commented
Status: Reviewed & tested by the community » Fixed
majmunbog’s picture

majmunbog commented
Status: Fixed » Closed (fixed)