The module currently relies on libraries module to find the library in non-standard paths. That project is not maintained and has an unknown future.
#3096648: Add support for third party libraries in site specific and install profile specific libraries folders aims to move the minimal functionality that is needed by most modules that rely on libraries directly in core.
Replace all libraries_get_path() calls with the new API.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | interdiff-3099836-3-9.txt | 1.43 KB | phenaproxima |
| #9 | 3099836-9.patch | 3.36 KB | phenaproxima |
| #7 | 3099836-7.patch | 4.56 KB | phenaproxima |
| #6 | 3099836-6.patch | 4.34 KB | phenaproxima |
| #3 | dropzonejs-libraries-directory-finder-3099836-3.patch | 3 KB | berdir |
Comments
Comment #2
berdirComment #3
berdirUpdating for the changed service and class name in core and also make this optional as it will only land in 8.9, and we still want to support libraries.module for 8.8. Once we require 8.9+, we can remove the old code like in the initial patch.
Should be able to commit this as soon as the core patch is in.
Comment #4
chr.fritschdropzonejs_library_info_alteralso needs to be adjustedComment #5
chr.fritschAnd I think the $exif_path should be added here:
Comment #6
phenaproximaThis should handle dropzonejs_library_info_alter().
Comment #7
phenaproximaOh, and this addresses the concern in #5.
Comment #8
berdirNo, the library alter is not required, that's the neat thing about this. It just works for libraries that are defined as /libraries/..., they are automatically resolved. Explicitly using the service is only needed for the requirements check and dynamically defined library.
See how that was completely removed in #2.
I did manually test my patch in #3 and it worked for me.
Comment #9
phenaproximaThanks for the clarification, @Berdir! I added a couple of todo comments to the patch in #3, and also fixed a potential call to
file_exists(false).Comment #10
berdirWell, I did write most of the code, so can't really RTBC, but lets say we cross-reviewed each others code ;)
Comment #12
chr.fritschOh, whoo 😲 I didn't realize that it does the job automatically.
So, awesome!