The module uses t function and drupal_set_message in its codebase which have been deprecated, they need to be removed and replaced with new apis and functions.

CommentFileSizeAuthor
#10 interdiff_8-10.txt1.39 KBlilit_ghazaryan
#10 gdpr_onetrust-remove_and_replace_deprecated_code-3099651-10.patch7.47 KBlilit_ghazaryan
#8 interdiff_5-8.txt2.61 KBrahulrasgon
#8 gdpr_onetrust-removed_and_replaced_deprecated_code-3099651-8.patch5.94 KBrahulrasgon
#5 gdpr_onetrust-removed_and_replaced_deprecated_code-3099651-5.patch5.82 KBhardik_patel_12
#3 gdpr_onetrust-removed_and_replaced_deprecated_code-3099651-3.patch6.77 KBrahulrasgon

Comments

guptahemant created an issue. See original summary.

rahulrasgon’s picture

rahulrasgon commented
Assigned: Unassigned » rahulrasgon
Status: Active » Needs work
rahulrasgon’s picture

rahulrasgon commented
Assigned: rahulrasgon » Unassigned
Status: Needs work » Needs review
StatusFileSize
new gdpr_onetrust-removed_and_replaced_deprecated_code-3099651-3.patch6.77 KB

Patch uploaded, please review.

Thanks

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: Unassigned » hardik_patel_12
Status: Needs review » Needs work
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new gdpr_onetrust-removed_and_replaced_deprecated_code-3099651-5.patch5.82 KB

@rahulrasgon replaced logger factory with messenger service for drupal_set_message

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
rahulrasgon’s picture

rahulrasgon commented
Assigned: Unassigned » rahulrasgon
Status: Needs review » Needs work
rahulrasgon’s picture

rahulrasgon commented
Assigned: rahulrasgon » Unassigned
Status: Needs work » Needs review
StatusFileSize
new gdpr_onetrust-removed_and_replaced_deprecated_code-3099651-8.patch5.94 KB
new interdiff_5-8.txt2.61 KB

Refactored the code. here's a fixed patch and interdiff.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs review » Reviewed & tested by the community

Thanks for the fixes @rahulrasgon. I have tested patch and it is working fine.

lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new gdpr_onetrust-remove_and_replace_deprecated_code-3099651-10.patch7.47 KB
new interdiff_8-10.txt1.39 KB

9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------------
Line modules/onetrust_cookie_blocking/onetrust_cookie_blocking.module
------ ------------------------------------------------------------------
95 Call to deprecated function file_default_scheme():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal::config('system.file')->get('default_scheme') instead.
99 Call to deprecated function file_default_scheme():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal::config('system.file')->get('default_scheme') instead.
------ ------------------------------------------------------------------

[ERROR] Found 2 errors

updated patch and no errors

9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

aliaksandr_rozum’s picture

aliaksandr_rozum commented
Status: Needs review » Reviewed & tested by the community

Hi @Lilit_Ghazaryan!
Your patch is fine.

drupal-check web/modules/contrib/gdpr_onetrust/
 9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
 [OK] No errors
gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented
Assigned: Unassigned » gobinathm
Status: Reviewed & tested by the community » Fixed

Commited in 2.x
https://git.drupalcode.org/project/gdpr_onetrust/commit/048658b

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.