Problem/Motivation

Bootstrap 4.4 is out, we should update.

CommentFileSizeAuthor
#14 update-bootstrap-3099362-14.patch14.36 KBpivica
#13 interdiff-3099362-12-13.txt1.74 KBpivica
#13 update-bootstrap-3099362-13.patch0 bytespivica
#12 update-bootstrap-3099362-12.patch12.85 KBpivica
#9 update-bootstrap-3099362-9.patch233.68 KBsasanikolic
#9 interdiff-3099362-8-9.txt558 bytessasanikolic
#9 Select inline.png50.87 KBsasanikolic
#8 update-bootstrap-3099362-8.patch233.94 KBsasanikolic
#8 interdiff-3099362-6-8.txt2.34 KBsasanikolic
#7 update-bootstra-3099362-6.patch233.95 KBpivica
#7 interdiff-3099362-5-6.txt2.48 KBpivica
#5 update-bootstra-3099362-5.patch232.69 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Category: Task » Plan

There is quite a few new stuff (https://github.com/twbs/bootstrap/releases/tag/v4.4.0) which will require time for checking and figuring should we use something of it. We also have some quite complex changes in #3099360: [META] alpha9 release issues (8.x-1.0-alpha9) release. Best is to postpone this for next release #3109163: [META] alpha10 release issues (8.x-1.0-alpha10).

pivica’s picture

pivica commented
Title: Update to Bootstrap 4.4 » Update to Bootstrap 4.5.2
Category: Plan » Feature request

Bootstrap released 4.5.2 (https://github.com/twbs/bootstrap/releases/tag/v4.5.2). We have two minor releases to catch up and couple of patch releases. Checked quicky, lots of stuff in 4.4.0, 4.5.0 and 4.5.1. Check releases in detail and create follow-ups if there is something interesting we can use.

Also update related bs_lib and update all related node libraries.

pivica’s picture

pivica commented

Bootstrap improved `bs-button()` mixin with better colors support (https://github.com/twbs/bootstrap/blob/main/scss/mixins/_buttons.scss). We can probably simplify or depreciate `bs-button-variant()` now.

pivica’s picture

pivica commented
StatusFileSize
new update-bootstra-3099362-5.patch232.69 KB

First patch ready.

pivica’s picture

pivica commented

The patch is dependent on other patches, specially floating labels patch.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3099362-5-6.txt2.48 KB
new update-bootstra-3099362-6.patch233.95 KB

Updated .browserslist.

sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new interdiff-3099362-6-8.txt2.34 KB
new update-bootstrap-3099362-8.patch233.94 KB 
+++ b/themes/bs_bootstrap/sass/components/partials/_forms.scss
@@ -340,7 +341,6 @@ details {
-    display: block;

Why was this removed? Our diffy is complaining because the select width is now very different than before. Is it safe to revert that?

Also, there's a new bootstrap release: https://blog.getbootstrap.com/2020/10/13/bootstrap-4-5-3/. Tried to update it here, not really sure what else needs to be done apart from these changes?

sasanikolic’s picture

sasanikolic commented
StatusFileSize
new Select inline.png50.87 KB
new interdiff-3099362-8-9.txt558 bytes
new update-bootstrap-3099362-9.patch233.68 KB

I think we should still keep the display block for the select mentioned above. I see that it is not defined in bootstrap, but that's because they have different use-cases and if needed, they wrap it in column wrappers? See https://getbootstrap.com/docs/4.5/components/forms/#form-controls.

Current look without display: block; for the select is attached in this screenshot - selects are inlined.

sasanikolic’s picture

sasanikolic commented

We should also look into this deprecation warning: The `make-container-max-widths` mixin has been deprecated as of v4.5.2. It will be removed entirely in v5..

pivica’s picture

pivica commented
Title: Update to Bootstrap 4.5.2 » Update to Bootstrap 4.6.x

Bootstrap 4.6 is out.

pivica’s picture

pivica commented
StatusFileSize
new update-bootstrap-3099362-12.patch12.85 KB

Here is a new patch against the latest dev that concentrates only on Bootstrap update to 4.6 and picking all fixes and optimizations from the previous patch. Node libs update are done in #3218996: Update node libs to latest versions and are removed here.

> Why was this removed? Our diffy is complaining because the select width is now very different than before. Is it safe to revert that?

No idea really, it does not make sense, let's keep it.

pivica’s picture

pivica commented
StatusFileSize
new update-bootstrap-3099362-13.patch0 bytes
new interdiff-3099362-12-13.txt1.74 KB

The $navbar-toggler-icon-bg and $navbar-toggler-icon-bg-light SASS variables needs to be in a new format that can be used with escape-svg() mixin.

pivica’s picture

pivica commented
StatusFileSize
new update-bootstrap-3099362-14.patch14.36 KB

Messed the last patch generation, here is the correct one.

  • pivica committed 5c243ee on 8.x-1.x 
    Issue #3099362 by pivica, sasanikolic: Update to Bootstrap 4.6.x
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.