Now that we can (finally!) depend on PHP 7, there is no reason anymore to include \Drupal\Core\Plugin\PluginDependencyTrait in \Drupal\search_api\Plugin\ConfigurablePluginBase (as explained in the comment there).
However, as the trait’s methods have now been included in the plugin base class, they are part of the public API which we can’t just change. We should therefore deprecate those methods and change the trait back to \Drupal\Core\Entity\DependencyTrait in the next major version (9.x-1.0 or whatever it ends up being).
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3099001-2--deprecate_PluginDependencyTrait_in_ConfigurablePluginBase.patch | 5.16 KB | drunken monkey |
Comments
Comment #2
drunken monkeyProbably something like this?
I also already created a change record.
Comment #3
mkalkbrennerI'm not aware of anything else than the SolrConnectors which are plugins of a plugin and have dependencies.
Therefore I suggest avoid that intermediate step to trigger these warnings.
Search API Solr 8.x-3.x requires PHP 7.1. And we're close to new release, so I could simply commit #3099065: Prepare for removing PluginDependencyTrait from ConfigurablePluginBase right now.
Comment #4
drunken monkeyIt’s unlikely, yes, but with dozens of modules building on the Search API we can’t really know for sure, so I think we should still keep to our established BC rules. (Especially since the patch and CR are already there.) We’ll then remove this soon enough.
Comment #6
drunken monkeyAlright, then: committed.
Thanks for your feedback.