Problem/Motivation

The Drupal 7 version allows development mode to be set. The D8 version doesn't have this option yet.

Proposed resolution

Add the option to the settings form.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 allow_development_mo-3098548-5.patch3.97 KBjhedstrom
#5 interdiff-3098548-4-5.txt416 bytesjhedstrom
#4 allow_development_mo-3098548-4.patch3.71 KBjhedstrom
#4 interdiff-3098548-3-4.txt479 bytesjhedstrom
#3 allow_development_mo-3098548-3.patch3.41 KBjhedstrom

Issue fork h5p-3098548

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Corresponding PR required to H5P core.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new allow_development_mo-3098548-3.patch3.41 KB
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new interdiff-3098548-3-4.txt479 bytes
new allow_development_mo-3098548-4.patch3.71 KB

I found an unused option 'dev_mode'. This updates to 'development_mode'.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new interdiff-3098548-4-5.txt416 bytes
new allow_development_mo-3098548-5.patch3.97 KB

Oops, found one more usage of 'dev_mode'.

pakmanlh’s picture

pakmanlh
he/him
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

The patch works nicely, thank you so much!

illeace’s picture

illeace commented

Dropping in to say this patch still seems to apply cleanly to the 2.0.0-alpha6 release.

sim_1’s picture

sim_1
she/her
commented
Version: 8.x-1.0-rc17 » 2.0.x-dev
sim_1’s picture

sim_1
she/her
commented

Creating a issue fork and MR for this. Checking to make sure it matches the patch file.

sim_1 opened merge request !40

  • sim_1 committed 1b81fdeb on 2.0.x 
    Issue #3098548 by jhedstrom, sim_1, pakmanlh, illeace: Allow development...
sim_1’s picture

sim_1
she/her
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone! Merged and marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.