I have just installed EU Cookie Compliance on a site with over 19 million nodes, and the regex query in _eu_cookie_compliance_find_privacy_policy() that tries to find a node that looks like a privacy policy has taken well over 10 minutes to run. This seems a bit unnecessary, I think there should at least be an opt-out for this behaviour, or just remove it entirely and rely on the user to select the correct node.

CommentFileSizeAuthor
#7 eu_cookie_compliance-remove-_eu_cookie_compliance_find_privacy_policy-since-it-is-extremely-slow-on-large-databases-3098484-7-8.x.patch2.68 KBsvenryen
#7 eu_cookie_compliance-remove-_eu_cookie_compliance_find_privacy_policy-since-it-is-extremely-slow-on-large-databases-3098484-7-7.x.patch3.08 KBsvenryen

Comments

longwave created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Hi, you're right, furthermore it doesn't make much sense for non-english websites. It's just a bonus and not required. I agree that should be encapsulated into a one-click bonus action on the module settings page or just be removed.

It may also lead to wrong suggestions and the 2nd and 3rd line are redundant here:

     title LIKE 'Privacy%' OR 
      title LIKE 'Privacy policy%' OR 
      title LIKE 'Privacy Policy%' OR

So I'd suggest to remove it completely and force the user to set the value after installation.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Minor
svenryen’s picture

svenryen commented

Let's just go ahead and remove it. What do you all think? It's a bit useless anyway unless your language is English.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Yep, I'd say so. We could think about a feature request for a similar functionality but I don't know how that could be done and I think setting this manually as mandatory field is ok!

svenryen’s picture

svenryen commented
Title: _eu_cookie_compliance_find_privacy_policy() is extremely slow on large databases » Remove _eu_cookie_compliance_find_privacy_policy() since it is extremely slow on large databases?
svenryen’s picture

svenryen commented
Status: Active » Needs review
StatusFileSize
new eu_cookie_compliance-remove-_eu_cookie_compliance_find_privacy_policy-since-it-is-extremely-slow-on-large-databases-3098484-7-7.x.patch3.08 KB
new eu_cookie_compliance-remove-_eu_cookie_compliance_find_privacy_policy-since-it-is-extremely-slow-on-large-databases-3098484-7-8.x.patch2.68 KB

Here's a patch that removes the functions.

svenryen’s picture

svenryen commented
Assigned: Unassigned » neslee canil pinto
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Version: 7.x-1.31 » 7.x-1.x-dev
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

@svenryen +1, marked this as RTBC.

  • svenryen committed c868cd4 on 8.x-1.x 
    Issue #3098484 by svenryen, Anybody, Neslee Canil Pinto, longwave:...

  • svenryen committed 6b70252 on 7.x-1.x 
    Issue #3098484 by svenryen, Anybody, Neslee Canil Pinto, longwave:...
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

  • svenryen committed 6b70252 on 7.x-2.x 
    Issue #3098484 by svenryen, Anybody, Neslee Canil Pinto, longwave:...
  • svenryen committed 87ed5ea on 7.x-2.x
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x: (26 commits)
  Issue #...
svenryen’s picture

svenryen commented
Assigned: neslee canil pinto » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.