Currently, config_ignore is depending on config_filter 1.x. which is not compatible with Drupal 8.8.

CommentFileSizeAuthor
#10 3098130-9.patch2.47 KBjeroent
#8 3098130-8.patch2.19 KBjeroent
#7 3098130-7-D8.8-only.patch847 bytesjeroent
#6 3098130-5-D8.8-only.patch286 bytesjeroent
#4 3098130-4.patch294 bytesjeroent
#2 3098130-2.patch290 bytesjeroent

Comments

JeroenT created an issue. See original summary.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3098130-2.patch290 bytes

Patch attached, makes it possible to download config_ignore 2.x. Still have to check if the module is compatible.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Active » Needs review
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3098130-4.patch294 bytes
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3098130-5-D8.8-only.patch286 bytes

Let' see if the tests still pass when config_filter 2.0 is used.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3098130-7-D8.8-only.patch847 bytes
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3098130-8.patch2.19 KB
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3098130-9.patch2.47 KB

Let's see what happens when we run the tests for config_filter v2.

jkswoods’s picture

jkswoods commented
Status: Needs review » Needs work

Having issues with this and 8.8. The patch applies fine, however, when using the new method for defining a config directory #3018145: The sync directory is defined in $settings and not $config_directories, the config synchronisation page fails to load. Perhaps test coverage could be improved to handle such a case (check if the config synchronisation page loads okay).

I've also tested the patch in #3099674: Create 3.x version using the new Drupal 8.8 API and although it has some larger changes it works fine.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Related issues: +#3099674: Create 3.x version using the new Drupal 8.8 API

Setting back to needs review so the maintainer can decide in which direction we're heading. Keep or remove the dependency on config_split. If the decision is to remove the dependency on config_split, then this issue can be closed as a duplicate of #3099674: Create 3.x version using the new Drupal 8.8 API

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

I'd prefer #3099674: Create 3.x version using the new Drupal 8.8 API as simplifies the module dependency and make use of core native capabilities.

rajab natshah’s picture

rajab natshah
he/him
commented

+1

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Closed (duplicate)