there is a 'font-size: normal' in the scss for the logo, this is not valid css (should/could be 1em/rem).

Because many themes already rely on this (so effectively no font-size is set for logo), it's better to remove it, so it doesn't break sites.

CommentFileSizeAuthor
#2 dvg-remove_unvalid_css-3098100-2.patch293.94 KBbskibinski

Comments

bskibinski created an issue. See original summary.

bskibinski’s picture

bskibinski
Primary language Dutch
Location Breda, The Netherlands
commented
Status: Active » Needs review
StatusFileSize
new dvg-remove_unvalid_css-3098100-2.patch293.94 KB

Effectively i've only removed "font-size: normal" from the CSS files.

But to be able to do this, I had to fix the SCSS files:

  • There was styling for events in the CSS, but that SCSS partial was never committed, so I restored the _events.scss partial.
  • There was styling for encrypted files in the SCSS, but this was never compiled to regular CSS, I've removed the styling in the SCSS, as to not break existing sites.

So in a nutshell, the CSS is the same except for the broken font-size:normal which is removed now.
And I changed the SCSS files to match the current CSS, so compiling won't produce any unexpected differences.

joshahubbers’s picture

joshahubbers commented
Status: Needs review » Reviewed & tested by the community

Works ok.

paulvandenburg’s picture

paulvandenburg commented
Title: Remove unvalid font-size CSS » Remove invalid font-size CSS
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.