Closed (fixed)
Project:
BS Base
Version:
8.x-1.x-dev
Component:
BS Bootstrap
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Nov 2019 at 18:36 UTC
Updated:
20 Dec 2019 at 14:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pivica commentedHere is a first patch, added maintenance page template that is using default structure from the main page template. Added a bit of CSS in a new maintenance library and inline SVG work in progress image so things don't look that boring ;)
Comment #3
pivica commentedAdded small vertical margin for a header logo so it does not stick to viewport top border.
Comment #4
pivica commentedHere are some screenshots
Comment #5
pivica commentedAdded more blocks in template so override is easier in child themes.
Comment #6
pivica commentedIt seems it's better to use padding-top then margin-top for div.region-brand element.
There is a possible problem when the sticky navbar is active - it seems it is running it's logic and applying a negative margin. Check this and fix it.
Comment #7
pivica commentedRemoved navmenu class from template and block class from navbar-brand selector which was enough to fix previously mentioned margin-top/padding-top rule - we do not need it any more.
Active sticky navbar was false positive, so not a bug.
Comment #8
pivica commentedComment #9
pivica commentedAdded new bs_base.maintenance_image.path theme configuration which we can use to store maintenance image path. Now custom projects can easily change this image.
Refactored maintenance-page template to extend from bs_bootstrap page template.
Comment #10
pivica commentedImage can be removed now, optimized CSS class names a bit.
Comment #11
pivica commentedForgot to move maintenance image to bs_base/images.
Comment #12
pivica commentedMoved bs_versions above so it does not conflict with Drupal packaging info lines - now we can use this in composer against the latest release.
Comment #13
pivica commentedDocumentation explaining this new feature is added in https://www.drupal.org/docs/8/themes/bs-base/additional-features/mainten....
Comment #15
pivica commentedRemoved extra container CSS class for div.region-navbar element. Committed.