Comments

pivica created an issue. See original summary.

pivica’s picture

Status: Active » Needs review
Issue tags: +next-release
StatusFileSize
new5.59 KB

Here is a first patch, added maintenance page template that is using default structure from the main page template. Added a bit of CSS in a new maintenance library and inline SVG work in progress image so things don't look that boring ;)

pivica’s picture

StatusFileSize
new5.64 KB

Added small vertical margin for a header logo so it does not stick to viewport top border.

pivica’s picture

StatusFileSize
new49.38 KB
new105.64 KB

Here are some screenshots

Before After
pivica’s picture

StatusFileSize
new5.93 KB

Added more blocks in template so override is easier in child themes.

pivica’s picture

Status: Needs review » Needs work

It seems it's better to use padding-top then margin-top for div.region-brand element.

There is a possible problem when the sticky navbar is active - it seems it is running it's logic and applying a negative margin. Check this and fix it.

pivica’s picture

StatusFileSize
new6.57 KB

Removed navmenu class from template and block class from navbar-brand selector which was enough to fix previously mentioned margin-top/padding-top rule - we do not need it any more.

Active sticky navbar was false positive, so not a bug.

pivica’s picture

Status: Needs work » Needs review
pivica’s picture

StatusFileSize
new8.52 KB

Added new bs_base.maintenance_image.path theme configuration which we can use to store maintenance image path. Now custom projects can easily change this image.

Refactored maintenance-page template to extend from bs_bootstrap page template.

pivica’s picture

StatusFileSize
new2.33 KB
new8.72 KB

Image can be removed now, optimized CSS class names a bit.

pivica’s picture

StatusFileSize
new8.66 KB

Forgot to move maintenance image to bs_base/images.

pivica’s picture

StatusFileSize
new8.74 KB

Moved bs_versions above so it does not conflict with Drupal packaging info lines - now we can use this in composer against the latest release.

pivica’s picture

Documentation explaining this new feature is added in https://www.drupal.org/docs/8/themes/bs-base/additional-features/mainten....

  • pivica committed d81841a on 8.x-1.x
    Issue #3097679 by pivica: Improve maintenance page
    
pivica’s picture

Status: Needs review » Fixed

Removed extra container CSS class for div.region-navbar element. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.