Problem/Motivation

fac.settings currently does not have a configuration schema.

Proposed resolution

Implement a configuration schema for fac.settings

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3097609-2.patch2.61 KBidebr
#2 3097609-2-test-only.patch1.23 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3097609-2-test-only.patch1.23 KB
new 3097609-2.patch2.61 KB

Attached patch implements the following changes:

  1. fac.settings now has a configuration schema
  2. The fac.settings added on install now has the correct data type and syntax.
  3. Added initial test coverage for the general settings. This Functional test also includes the Schema checker, so the automated tests will fail when there is any configuration without an associated schema.
idebr’s picture

idebr commented

It appears automated tests are not enabled on the Drupal infrastructure. This can be enabled in the project settings by a maintainer at https://www.drupal.org/node/2549423/qa

  • Marty2081 committed b056a2f on 8.x-1.x authored by idebr 
    Issue #3097609 by idebr: Implement a configuration schema for fac....
marty2081’s picture

marty2081 commented
Status: Needs review » Fixed

Thanks. Added the schema for fac.settings.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sutharsan’s picture

sutharsan commented

It looks like not all parts of the patch have been committed.
fac.settings.ym has not changed and the test file is missing. See https://git.drupalcode.org/project/fac/-/tree/8.x-1.x/src