Part of #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch

Only one migration plugin with mention in comments

CommentFileSizeAuthor
#5 interdiff_2-5.txt2.15 KBmeenakshig
#5 3097476-5.patch3.97 KBmeenakshig
#2 3097476-2.patch1.58 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
StatusFileSize
new 3097476-2.patch1.58 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove all @deprecated code in the Config tanslation module » Remove all @deprecated code in the Config translation module

Status: Needs review » Needs work

The last submitted patch, 2: 3097476-2.patch, failed testing. View results

meenakshig’s picture

meenakshig commented
Status: Needs work » Needs review
StatusFileSize
new 3097476-5.patch3.97 KB
new interdiff_2-5.txt2.15 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

@Meenakshi.g thanks! missed this test

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs review 
+++ b/core/modules/migrate/src/Plugin/migrate/destination/EntityConfigBase.php
@@ -40,7 +40,7 @@
- *   plugin: d6_i18n_profile_field
+ *   plugin: d6_profile_field_translation

can you elaborate on why this change is needed?

thanks

andypost’s picture

andypost
he/him
Primary language Russian
commented

Because example using deprecated plugin id

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Back to rtbc, because in patch #2 the d6_i18n_profile_field deprecated plugin class removed and it's only mention by plugin ID removed

  • catch committed 30ec97c on 9.0.x 
    Issue #3097476 by Meenakshi.g, andypost: Remove all @deprecated code in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 30ec97c and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.