We had to decorate the MenuLinkTree service and found that this module doesn't use the interface in the construct of the EntityMenuLinkContentUrlGenerator class. This produces a fatal error when regenerating the sitemap.

I'm attaching a patch to fix this. (We're using 8.x-2.x but I also created a patch for 8.x-3.x)

CommentFileSizeAuthor
#2 use-interface-8.x-3.x-1.patch1.54 KBdagomar
#2 use-interface-8.x-2.x-1.patch1.49 KBdagomar
use-interface-8.x-3.x-1.patch1.2 KBdagomar
use-interface-8.x-2.x-1.patch1.14 KBdagomar

Comments

dagomar created an issue. See original summary.

dagomar’s picture

dagomar commented
StatusFileSize
new use-interface-8.x-2.x-1.patch1.49 KB
new use-interface-8.x-3.x-1.patch1.54 KB

Sorry I messed up, I forgot to update the 'use' statement.

  • gbyte.co committed 1d8af8f on 8.x-3.x 
    Issue #3097353 by dagomar,gbyte.co: EntityMenuLinkContentUrlGenerator...
gbyte’s picture

gbyte
Location Berlin
commented
Category: Bug report » Task
Status: Active » Fixed

Albeit not a bug fix, the patch is appreiciated. I'm afraid however 2.x has been unsupported for a long time so I won't be pushing to it. There should be no reason for you not to switch to 3.x though, as there is an upgrade path.

dagomar’s picture

dagomar commented

Thanks @gbyte.co,

Incidentally a colleague had yesterday done an update and we're now on 3.x :). That was a thing as right before adding the patch I pulled in develop and the 2.x patch failed :D. Shenanigans. Anyway, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.