#3096916: Generate reverse relationships for base entity references fixed entity_reference reverse relationships and #3057438: Move the commerce_order_views_data_alter() state_machine workaround to CommerceEntityViewsData fixed state fields.

We are still missing CommerceEntityViewsData workarounds for the following field types:
- address / address_country
- list_float / list_integer / list_string
- datetime

For datetime we want to only include the argument and sort handlers for now. The filter handler performs timezone conversion which would be wrong for "store datetime" fields, so we'll want to do that one in a followup. Broad strokes for now.

CommentFileSizeAuthor
#2 3096931-2-add-views-data.patch7.54 KBbojanz

Comments

bojanz created an issue. See original summary.

bojanz’s picture

Status: Active » Needs review
StatusFileSize
new7.54 KB

Added the datetime filter here after all. The store datetime override will be added by PromotionViewsData in #3096953: Create a StoreDate views filter, use it in Promotions .

Datetime fields also have year/month/day arguments, which can be seen here: https://git.drupalcode.org/project/commerce_reports/blob/8.x-1.x/commerc...
Couldn't figure out how to do that from inside processViewsDataForDatetime(), so that too will have to wait for a followup.

  • bojanz committed 70ae7b2 on 8.x-2.x
    Issue #3096931 by bojanz: Add missing views data for address, date, list...
bojanz’s picture

Status: Needs review » Fixed

Committed.

bojanz’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.