We need to convert SimpleTest tests to FunctionalJavascript.

CommentFileSizeAuthor
#9 3096857-9.patch21.61 KBphenaproxima
#8 3096857-8.patch21.55 KBphenaproxima
#7 3096857-7.patch21.64 KBphenaproxima
#5 3096857-5.patch21.62 KBphenaproxima
#4 3096857-4.patch11.52 KBphenaproxima
#2 embed-convert_SimpleTest_to_FunctionalJavaScript-3096857-2.patch12.64 KBandreyjan

Comments

andreyjan created an issue. See original summary.

andreyjan’s picture

andreyjan commented
Status: Active » Needs review
StatusFileSize
new embed-convert_SimpleTest_to_FunctionalJavaScript-3096857-2.patch12.64 KB

And the patch ...

andreyjan’s picture

andreyjan commented
Status: Needs review » Needs work
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3096857-4.patch11.52 KB

Turns out that two of the three tests can be converted to plain browser tests, rather than JavaScript tests. This patch converts those two; I'll tackle the test that does need JavaScript in a subsequent patch.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3096857-5.patch21.62 KB

Okay, that was kind of a dopey error :) I guess I'll convert the JavaScript test now! :)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Convert SimpleTest tests to FunctionalJavascript » Convert SimpleTest tests to PHPUnit

Re-titling for accuracy.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3096857-7.patch21.64 KB

Whoops, forgot to remove an assertResponse() call.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3096857-8.patch21.55 KB

And, converting some assertText() and assertNoText() calls to their JsWebAssert equivalents.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3096857-9.patch21.61 KB

Added a missing drupalGet() call.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good and passes, nice work, thank you!

  • Dave Reid committed efe457b on 8.x-1.x authored by phenaproxima 
    Issue #3096857 by phenaproxima, andreyjan: Converted SimpleTest tests to...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.