Book performance problem in book_node_load

The patch does not applied anymore. Uploading a reroll with some cosmetic changes (like that we do not need to create a second array of nodes if all we need are NIDs).

Hmm, it seems like that the failures are not a problem of this patch, but are related to the allowed_types settings.

In those failing migration tests this settings returns NULL. Then it will throw PHP 8 typerror:

TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given

So I think we need to either fix those migration tests, or change the book_type_is_allowed() function to count on the possibility, that NULL can be returned.

function book_type_is_allowed($type) {
  return in_array($type, \Drupal::config('book.settings')->get('allowed_types'));
}

Either way it seems to me that a new issue should be created for this, as this is out of scope of this. Any thoughts?

Added a related issue where D7 was able to fix this relatively simply as hook_node_load() is passed a list of $types.

It looks like the function is just sloppy, and yes, we should make sure getting the config gives you and array (and/or cast it to array).

Also, if you are possibly loading many nodes here, it would be faster (IDK if enough to matter?) to inline the check to reduce the number of confg get() calls you have to make?

This turned out to be more complicated, since the allowed_types variable cannot be relied upon. Users with "Administer book outlines" permission can add all types to book outlines. Therefore if we restrict book_node_load for such nodes, it will make these books unusable.

See:
#2862291: [Duplicate] Book outline not limited to allowed content types
#502430: Allow the book outline functionality on non-book-enabled node types to be hidden from users with the "Administer book outlines" permission

If this behavior is a feature, as explained in those linked issues, this needs to be at least postponed until mentioned issues are resolved. Second option is to close this as Won't fix, but the performance issues are there and better to think how we can solve them.

This extension is being deprecated, see #3376070: [Meta] Tasks to deprecate Book module. It will be removed from core and moved to a contrib project, #3376101: [11.x] [Meta] Tasks to remove Book.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

This issue may be re-opened if it can be considered critical, If unsure, re-open the issue and ask in a comment.

Just merged #502430: Allow the book outline functionality on non-book-enabled node types to be hidden from users with the "Administer book outlines" permission wonder if this is now still needed?