------ ----------------------------------------------------------------------
  Line   force_password_change.module
 ------ ----------------------------------------------------------------------
  217    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  320    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  393    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/EventSubscriber/ForcePasswordChangeEventSubscriber.php
 ------ ----------------------------------------------------------------------
  128    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  133    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/AdminForm.php
 ------ ----------------------------------------------------------------------
  364    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  368    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/RoleForceForm.php
 ------ ----------------------------------------------------------------------
  150    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  154    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ -------------------------------------------------------
  Line   src/Service/ForcePasswordChangeService.php
 ------ -------------------------------------------------------
  326    Call to deprecated function user_load_multiple():
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use
         \Drupal\user\Entity\User::loadMultiple().
 ------ -------------------------------------------------------
CommentFileSizeAuthor
#24 3096554-21.patch794 byteslarisse
#22 3096554-21.patch794 byteslarisse
#21 error_patch.png77.25 KBlarisse
#20 patch096554-19_0.png53.19 KBlarisse
#19 096554-19.patch4.01 KBlaisbonafe
#15 fpc_clean.png63.13 KBguilhermevp
#14 d9-3096554-14.patch6.06 KBmistrae
#13 d9-3096554-13.patch6.05 KBmistrae
#12 interdif.patch913 bytesmvogel
#12 d9-3096554.patch5.71 KBmvogel
#12 info-file-3096554.patch760 bytesmvogel
#9 3096554-2.patch5.72 KBheddn
#8 fpc-D9-support-3096554-8.patch82.79 KBdrupal.ninja03
#3 interdiff-02-03.txt7.24 KBedycarreyes99
#3 fpc-D9-support-3096554-03.patch7.24 KBedycarreyes99
#2 3096554-2.patch5.72 KBDeeksha B

Comments

Deeksha B created an issue. See original summary.

Deeksha B’s picture

Deeksha B commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3096554-2.patch5.72 KB
edycarreyes99’s picture

edycarreyes99 commented
Assigned: Unassigned » edycarreyes99
StatusFileSize
new fpc-D9-support-3096554-03.patch7.24 KB
new interdiff-02-03.txt7.24 KB

patch not apply, fixing that.

drupal.ninja03’s picture

drupal.ninja03 commented

.

drupal.ninja03’s picture

drupal.ninja03 commented
Issue summary: View changes
drupal.ninja03’s picture

drupal.ninja03 commented
Status: Needs review » Needs work

Patch from #3 didn't work for me:

$ git apply ~/Downloads/fpc-D9-support-3096554-03.patch
error: patch failed: force_password_change.info.yml:1
error: force_password_change.info.yml: patch does not apply
error: patch failed: force_password_change.module:320
error: force_password_change.module: patch does not apply
drupal.ninja03’s picture

drupal.ninja03 commented
Issue tags: +Needs reroll
drupal.ninja03’s picture

drupal.ninja03 commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new fpc-D9-support-3096554-8.patch82.79 KB

Created a fresh patch as the previous ones failed probably due to indentation errors.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Assigned: edycarreyes99 » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3096554-2.patch5.72 KB

That's a lot of whitespace changes. Let's re-upload #2, which is working on a live D9 site.

drupal.ninja03’s picture

drupal.ninja03 commented

Hi @heddn, did you test the patch I uploaded? Did it not work for you?

The whitespace changes were automatically fixed by the code sniffer CLI tool.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

@drupal.ninja03, this issue is that there are too many whitespace changes and it would be nearly impossible to know what changed. Much better to do whitespace cleanup in another issue. And keep the fixes limited to only D9 support here. Which is why I went back to #2.

mvogel’s picture

mvogel commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new info-file-3096554.patch760 bytes
new d9-3096554.patch5.71 KB
new interdif.patch913 bytes

I couldn't apply the patch.

I wrote an info yml file patch to delete the information added by the Drupal.org packaging script. So if you want to apply the D9 patch you need to run the info-file.patch first. I don't know where this packaging script came from and how to patch it properly.

For the D9 Patch, I had to change some line numbers and array syntax to apply correctly. (see interdif)

mistrae’s picture

mistrae commented
StatusFileSize
new d9-3096554-13.patch6.05 KB

Wrong patch

mistrae’s picture

mistrae commented
StatusFileSize
new d9-3096554-14.patch6.06 KB

Changing $this->messenger->addMessage( to \Drupal::messenger()->addMessage( as it errors the following : Call to a member function addMessage() on null

guilhermevp’s picture

guilhermevp commented
Title: Drupal 9 Deprecated Code Report » Call to deprecated function drupal_set_message()
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new fpc_clean.png63.13 KB

Patch works as intended in the scope of the proposed issue. But there is more deprecated code to be addressed.
Updated the issue title to reflect the scope.

guilhermevp’s picture

guilhermevp commented
Title: Call to deprecated function drupal_set_message() » Call to deprecated function drupal_set_message() / Call to deprecated function user_load_multiple()
larisse’s picture

larisse commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Needs work

Needs reroll for 2.0.x branch

laisbonafe’s picture

laisbonafe commented
Assigned: Unassigned » laisbonafe
laisbonafe’s picture

laisbonafe commented
Assigned: laisbonafe » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 096554-19.patch4.01 KB

Hi, I did a re-roll of the patch #14.

larisse’s picture

larisse commented
Assigned: Unassigned » larisse
Status: Needs review » Needs work
StatusFileSize
new patch096554-19_0.png53.19 KB

The patch #19 could not be applied.
I will try to work on this.

larisse’s picture

larisse commented
StatusFileSize
new error_patch.png77.25 KB

Opss, this is the error that I get when I try to apply the patch #19

larisse’s picture

larisse commented
Assigned: larisse » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3096554-21.patch794 bytes

A reroll for 2.0.x branch.

  • larisse committed 44d7ad5 on 2.0.x 
    Issue #3096554 by mvogel, Mistrae, larisse, edycarreyes99, drupal....
larisse’s picture

larisse commented
Status: Needs review » Fixed
StatusFileSize
new 3096554-21.patch794 bytes

Thank you all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

orb’s picture

orb commented
Priority: Normal » Critical

everything is good