Closed (fixed)
Project:
Drupal core
Version:
8.9.x-dev
Component:
migration system
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Nov 2019 at 12:13 UTC
Updated:
10 Dec 2019 at 21:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
longwaveComment #3
wim leersWell this turned out to be the simplest core patch I've created in a while 😇
Comment #4
wim leersThanks, @longwave!
Marked that as a duplicate, see #3051315-2: Disabled filter formats migrated and re-enabled for details. Lifting tags and credit from that issue.
Comment #5
wim leersApparently I was unable to credit
@hass. Can a core committer please do that?Comment #6
wim leersNote that @hass is the one who tagged it . I agree with his assessment. With the D7 → D8 migration in HEAD, it's possible to use formats again in D8 that were disabled a long time ago in D7: they show up in the text format dropdown. That justifies the priority of which @hass set.
Comment #7
wim leersBeen told that I should put this in
migration system:)Comment #8
wim leersComment #9
init90nice fix :)
Comment #10
quietone commentedSorry, but this should have a test. It looks like a test of the status value needs to be addd to the assertEntity in MigrateFilterFormatTest.php.
Comment #11
longwaveAdded a test for the status as suggested. I also disabled the PHP code filter in the fixture so we can test this change.
Comment #12
quietone commented@longwave, thanks the test checks both source status of '0' and '1'. Looks goo to me.
Comment #14
wim leersThanks, @longwave!
Re-RTBC'ing per #9 + #12. I also reviewed the test-only patch in #11.
Comment #17
heddnRe-adding patch from #11 w/o the test only patch so RTBC testbot doesn't keep falling over on it.
Comment #21
webchickOh dear. :) Very nice catch!
Committed and pushed to 9.0.x; 8.9.x; 8.8.x (since I highly doubt an one-line, arguably security fix, with no BC implications is going to be controversial). Thanks!