WebDriverTestBase has its own assertSession(), there is no reason to override it.

I am unsure why this was originally done. Possibly to avoid the deprecation errors triggered by WebDriverWebAssert(). But if our tests are triggering some, then they should be fixed.

CommentFileSizeAuthor
#2 3095320-2-assert-session.patch757 bytesbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Active » Needs review
FileSize
3095320-2-assert-session.patch757 bytes

Let's ask the testbot.

  • bojanz committed a9d3b62 on 8.x-2.x 
    Issue #3095320 by bojanz: CommerceWebDriverTestBase should not redefine...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

We're good!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.