The WYSIWYG module has a new release that incorporates 4 of the patches Panopoly is using, see Release Notes. According to that page, the released version doesn't support PHP 5.3 anymore because of a change in array syntax. If Panopoly still needs to support PHP 5.3, then there is a commit in the WYSIWYG module dev branch that uses the old array syntax.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | panopoly_test-update-wysiwyg-3094890-13.patch | 3.04 KB | dsnopek |
| #2 | panopoly_wysiwyg-update-wysiwyg-3094890-2.patch | 1.28 KB | cboyden |
Comments
Comment #2
cboyden commentedPatch is attached. If PHP 5.3 support is necessary I can update it to include that.
Comment #3
dsnopekHere's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/633937130
Comment #4
dsnopekManual testing looked good!
I've got mixed feelings on PHP 5.3 support. Our tests haven't been running on PHP 5.3 for a while anyway. And I don't know that we really want to commit to patching all contrib modules for PHP 5.3 going forward for a version of PHP that was EOL'd over 5 years ago. I'm going to commit this and we'll see if any PHP 5.3 fans come out of the woodwork. :-)
Comment #6
dsnopekCommitted!
Comment #8
dsnopekAfter merging, this appears to break our tests:
https://travis-ci.org/panopoly/panopoly/builds/634477995
I'm not sure why my original test run on Travis came back green... I'm going to look into that.
Here's a new test running with this change reverted:
https://travis-ci.org/panopoly/panopoly/builds/634775305
If that passes, then we know we need to fix this one up.
Comment #9
dsnopekYeah, the tests with the change reverted seem to be passing.
I think the reason the tests didn't catch it the first time is because I keep forgetting to run 'robo build:drupal-org-make' to accommodate the monorepo, so I added a git pre-commit hook to the RoboFile to try and prevent me from committing without running that. :-)
Anyway, the test failure is just an alert appearing that the tests don't expect:
Comment #10
cboyden commentedHere's a patch that adds some steps that confirm or cancel a browser popup, and then adds them to the live preview WYSIWYG test.
Comment #11
dsnopekHere's a Travis build that will hopefully be accurate this time:
https://travis-ci.org/panopoly/panopoly/jobs/634925485
I'm gonna try running this locally too.
Comment #12
dsnopekManual testing worked again (I wanted to redo it, just in case I was using the wrong versions locally).
Tests on Travis are failing, though, with:
Could be a timing thing? The test is passing for me locally.
Here's a patch that adds a short wait.
EDIT: Here's a new Travis build: https://travis-ci.org/panopoly/panopoly/builds/634948363
Comment #13
dsnopekAlright, that didn't work! Let's try this.
EDIT: Here's a new Travis build https://travis-ci.org/panopoly/panopoly/builds/635457251
Comment #15
dsnopekWell, that seemed to work! Committing :-)