Drupal 9 Deprecated Code Report

Remove outdated tag.

Added default theme in ContactAjaxTest and support drupal from 8.8

Removing `core:` attribute from info file

The line needs to stay there when changing back to ^8 from ^8.8. Please see https://twitter.com/kristen_pol/status/1263651488678572034?s=20.

Updated patch as suggested in #11, please review.

Thanks for the update. Nitpick:

+++ b/contact_ajax.info.yml
@@ -1,7 +1,8 @@
+name: Contact Ajax ¶

Extra space after name.

Thanks for the review. I have updated the patch and fixed the extra spacing issue as mentioned in #14, please review.

Ops was not intentional removing 8.8.
Thanks Kristen reverted to 8.8 and removed `core`

Uh ok we need to convert also `drupalPostAjaxForm`

To be fair Drupal\Tests\field_ui\Traits\FieldUiTestTrait has been introduced since 8.6.x. Also these classes concerns tests only and the module would still work on any 8.x version. Patch #15 should be used IMHO.

@elgandoz i still in doubt about the compatibility in the core version, i moved back to ^8 by the way.

The patch contain an idea of how the testes should look like without the submitAjaxForm method.
I haven't run yet this tests but it should be very close

Make changes to make this module compatible with drupal9 as well.

Hi mukeshkanzariya,

Please provide an interdiff when you work on an existing patch, will be easier follow the changes you did.
Also consider that the changes you did are not enough to use FunctionalJavascript, please see the patch in #20.
Can you argument your idea?

Patch #20 seems good and works.
Watch is missing for this module to have a D9 compatibility ? I'm ok to help if needed.

Hi Dom,

Tests are failing, is the only thing missing. But i guess is better split the task in 2 steps, so release a version compatible with D9 without tests and work on separate issue to fix them.

That would at least allow to a clean install of the module via composer (thus in CLI pipelines) on D9 projects.

----------------------

/src/Tests/ContactAjaxTest.php

 namespace Drupal\contact_ajax\Tests;

tests should now be extracted from src and moved to a "tests" folder aside.

/src/Tests/ContactAjaxTest.php

/**
 * Tests storing contact messages and viewing them through UI.
 *
 * @group contact_storage
 */

Some copy-paste left-over.

/src/Tests/ContactAjaxTest.php

use FieldUiTestTrait;

This fills useless here

/src/Tests/ContactAjaxTest.php

$this->assertText()

Those are deprecated. I guess this is why they are not compatible with the JS tests here with the response header checks.

/src/Tests/ContactAjaxTest.php

$this->drupalPostAjaxForm()

This method maps to nothing
----------------------

I really would like to see this module happen for Drupal9 since it is somewhat difficult to not being able to use it via composer.

I have done somes changes in the test file (appart from moving it), mainly because of the 'javascript' process that runs on WebDriverTestBase. Contrarily to BrowserTestBase, JS is enabled and drupalPostForm where there is ajax involved is a bit more complicated to use.

Patch is attached and should (finger cross) pass test checks (as it does locally).

Committed to dev.

Commit credit to all people involved,

Thank you.