Right after the automatic updates module is installed the status message that "your site has not recently run an update readiness check." is showing up (see update.png) . If you follow up on the link within the "there was a problem checking available updates for your modules or themes" the status message regarding the readiness check persists without an actionable link like the "available updates" status message has. It would be convenient to either point to run the readiness check directly:

http://drupalzip.ddev.site/admin/config/automatic_updates/readiness

or point to the automatic updates settings so the admin is able to set the desired options beforehand:

http://drupalzip.ddev.site/admin/config/automatic_updates

I would rather prefer the latter so it is an informed decision what to check and how to proceed in regards of an error. And it would save a few clicks and the search for the automatic updates preferences also.

CommentFileSizeAuthor
#12 3093866-12.patch6.19 KBheddn
#8 Screenshot from 2019-11-22 11-36-29.png11.35 KBheddn
#8 3093866-8.patch1.58 KBheddn
#5 3093866.patch1.19 KBrkoller
#3 error.png33.32 KBrkoller
update.png48.09 KBrkoller
extend.png78.77 KBrkoller

Comments

rkoller created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Novice

Sounds reasonable. Want to work on it?

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
StatusFileSize
new error.png33.32 KB

hmmm I not really consider myself as a programmer, am more into the field of Content Strategy, UX and alike. Someone else might be more suitable for the issue. But gave it a quick try out of curiosity (see error.png). The only problem I ran into is that the second link isn't resolved properly. I've used: 

t('Your site has not recently run an update readiness check. You can either evaluate the <a href="@readiness_settings">Automatic Updates settings</a> first or directly run the <a href="@readiness_checks">readiness check</a>.', ['@readiness_settings' => Url::fromRoute('automatic_updates.settings')->toString()], ['@readiness_checks' => Url::fromRoute('automatic_updates.update_readiness')->toString()])

Or would it preferably only to link to the settings page anyway?

heddn’s picture

heddn
Primary language English
Location Illinois
commented

I think it makes sense to have only a single link to the settings page. Could you roll this into a patch? If you are using a git clone of this project, a simple <from automatic_updates directory> git diff >3093866.patch, then upload the file here would do.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
StatusFileSize
new 3093866.patch1.19 KB

uffff I tried. Please bare with me if anything went wrong. :/ Probably I did a bit too much. But I've cloned the git repo then created a branch with the issue number (that part I possible could have skipped). Then checked out to that branch and then changed the two lines in the automatic_updates.module file. After that I did git diff automatic_updates.module > 3093866.patch. The patch I've appended. Hope it is ok. If I did anything wrong or unnecessary please let me know. :)

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review

Looks good so far. Let's change the status and see how the testbot likes it.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented

One question. After the informations I got in the issue here: https://www.drupal.org/project/automatic_updates/issues/3093967 and I want to update the the diff. Is it necessary to pull the branch to get to the current state? or could I simply change the specific line again and redo the diff without a pull? Wanted to change the upper case of Automatic Updates to Automatic updates

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue summary: View changes
StatusFileSize
new 3093866-8.patch1.58 KB
new Screenshot from 2019-11-22 11-36-29.png11.35 KB

Yes, you would want to update things. Here's an updated patch and screenshot of the wording.

I've reworded it to:

Your site has not recently run an update readiness check. Administer automatic updates and run readiness checks manually.

No interdiff as it seems things needed a re-roll. But this is short enough...

  • heddn committed 11e8a0f on 8.x-1.x 
    Issue #3093866 by rkoller, heddn: Add a clickable link to the readiness...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Committed and pushed to 8.x. Needs backport to 7.x

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.x-1.0-alpha3 » 7.x-1.x-dev
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
StatusFileSize
new 3093866-12.patch6.19 KB

  • heddn committed 81823dc on 8.x-1.x 
    Issue #3093866 by heddn, rkoller: Add a clickable link to the readiness...

  • heddn committed e0af43a on 7.x-1.x 
    Issue #3093866 by heddn, rkoller: Add a clickable link to the readiness...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.