November 18, 2019 - Meeting Agenda [#3093794]

Meeting Agenda

Introductions
Accessibility review report: https://paper.dropbox.com/doc/Olivero-Accessibility-Meeting-Notes-Nov-15...
- #3094774: Implement <button> elements for each main menu sub-menu
- #3094776: Better accessibility with menu wrapping elements
Synchronous tasks that can take place while building PoC
#3092312: Create list of needed tools to help with theme development

Meeting Details

Time: 3pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

:zero: If you’re attending this meeting, please 1) Let us know here, and 2) comment in the meeting agenda issue above so we can give issue credit on d.o

mherchel	I’m attending!
MaddieC	I am attending :)
Jen Witkowski	I'm attending!
felix	Hi :wave:
shaal	Ofer Shaal, Flroida :sunglasses: :snowflake:
Chris Bovard	I am here.
Putra Bonaccorsi	I'm attending!
mtift	Hello!
starshaped (she/her)	Hi there, I’m here and attending!
andrewmacpherson	By good fortune, I just saw opened Slack at the same time this was happening :slightly_smiling_face:
Natalie Cainaru	Hello!!
Bhavin Joshi (he/him)	I am in.
iggy_lakic	Hello, I'm here & attending!
vulcanr	Arrived late :disappointed:

:one: Accessibility report

mherchel	We met with two of the Drupal Accessibility maintainers on Friday (Andrew and Rain), and talked mostly about the site header and navigation. The two issues that resulted from this are #3094776: Better accessibility with menu wrapping elements. Overall the meeting went very well! I feel like we have a good grasp on what needs to be accomplished in the PoC phase
andrewmacpherson	Thanks for filing the issues. I clarified some already.
mherchel	Note that one of the goals is to get a signoff on the page from the accessibility maintainers
mherchel	Most of the issues are accessibility related, and I started triaging them in #3094697: Meta: Proof of concept completion
mherchel	Does anyone have any thoughts, ideas, etc?
Bhavin Joshi (he/him)	How about give them a try one a time and create another iteration for testing? That will be one step closer
mherchel	@Bhavin Joshi (he/him) give what a try, each issue?
Bhavin Joshi (he/him)	I mean, we implement them after discussing them.
Putra Bonaccorsi	@mherchel Makes sense! Thanks for listing out all of the items needed for the POC completion. Do you have sense of when they should all be done by? End of month? I know that there's desire to get into the Drupal theming work.
mherchel	@Bhavin Joshi (he/him) If there’s discussion, now’s the time (either here or in the issue queue). Then we’ll implement them in the PoC prior to final PoC signoff
Bhavin Joshi (he/him)	Yes, right. Indeed. @mherchel
Bhavin Joshi (he/him)	That is what I wanted to convey
mherchel	@Putra Bonaccorsi thank you! I’d love to be done with these issues by the end of the month. I feel like we know where we need to go (which is half the battle).
Natalie Cainaru	For the implementation of in the main menu and sub-menu, it might be worth looking at what the Umami theme had done. IIRC, they ran into a similar issue
mherchel	That being said, I also recognize that the timeline is very ambitious — esp since we’re all volunteers
mherchel	@Natalie Cainaru if you have a specific issue # that would really help out (and post into the issue).
mtift	And I'm guessing that we can get sign off, but that accessibility will be a continuous topic of conversation
Natalie Cainaru	@mherchel sure! Let me find them, one moment
felix	I wondered why we left (the majority of the) elements displayed in the design out of the poc especially input/form elements, aren't they important for accessibility signoff?
mherchel	that being said, the markup and implementation listed within the issue has been looked over and approved by the accessibility maintainers. Once we implement this, we should be good
mherchel	@felix they are important! Either they already meet guidelines, or were missed
mherchel	that being said, changing the style of various form elements is also easier to do late in the process, as opposed to changing the architecture of our header, which is somewhat complex
felix	I see, so we go straight to drupal theme with them :+1:
mherchel	Once we have the PoC approved from an accessibility standpoint and working cross browser without any major bugs
Natalie Cainaru	@mherchel added a comment to the issue with the two issues I found
mherchel	Thank you! (edited)
andrewmacpherson	Filed a new issue. This isn't something that was discussed in last Friday's a11y meeting. #3095152: Separate the focus and error styles for form elements

:two: Synchronous tasks that can take place while building PoC

mherchel	I feel like there are some tasks that we can take on within the actual theme, that are not dependent on work to be done on the PoC. I’d like to start gathering a list of these.
mherchel	Something that comes to mind is that all of the hyperlinks within the primary menu require a nested added via preprocess
mherchel	There are probably several issues similar to that
mherchel	Does anyone else have anything that comes to mind?
Bhavin Joshi (he/him)	3092221, but it is going to be covered with 3094774[#3094774] (edited)
mherchel	That issue is more of a JavaScript front-end issue that would need to be resolved in the PoC. I’m more looking for backend tasks that might have to be tackled in preprocess or theme settings
Putra Bonaccorsi	@mherchel Agreed! We also need to add standard preprocess functions (eg. `preprocess_html`) for any unique classes that we'll need in the header.
shaal	Are there parts of the theme that are already approved by accessibility team that can already be drupal-themed? or we'll start that only after the POC is approved as a whole ?
Putra Bonaccorsi	Do we have an issue discussion opened for this topic? If not, I can create one and folks can add what they think can be done in the meantime. (edited)
andrewmacpherson	@shaal - yes, some of these can be started. Check the individual issues for details.I'm not much bothered about the distinction between the PoC HTML demo and the actual Drupal theme. The important thing is the Olivearo team have started addressing accessibility at an early design stage. Major issues have been recognized, and plans formed to address them. But I'm not fussy what stage the fixes arrive in.
mherchel	@Putra Bonaccorsi we do not have an issue! I’d love love love if you could do it!
Putra Bonaccorsi	@mherchel Yes! I can take care of that!
Putra Bonaccorsi	@mherchel Here's the ticket - #3095181: Create a list of tasks/items that can be worked on while building POC. I think we have a few solid line items that can be broken out into tickets.

:three: List of tools to help with theme development #3092312: Create list of needed tools to help with theme development

mherchel	@Bhavin Joshi (he/him) created some notes at https://www.dropbox.com/scl/fi/p8zh7cu0texf9jidr25b7/Development-tools-f...
mherchel	(Thank you!)
Bhavin Joshi (he/him)	Thank you!
mherchel	Does anyone else have thoughts on additional tools, and how to implement them?
shaal	I added a few into the bottom of that document

:four: Any other thoughts, blockers, questions?

mherchel	I started a meta issue to track our current open issues at #3094697: Meta: Proof of concept completion (edited)
mherchel	Special thanks to @vulcanr for working on #3094867: JS Only Behaviour for Mobile Navigation and other issues! (edited)
mtift	@vulcanr ++
mherchel	also special thanks to @andrewmacpherson and @rain for taking time out of their busy days to talk accessibility
mherchel	I feel that meeting was super productive!
shaal	I made a contrib kanban version for the Meta: Proof of concept completionhttps://contribkanban.com/node-board/871176c7-4b70-476c-b89f-138eb95ca02f
mherchel	special thanks to @MaddieC for working on #3092337: Create messages block within proof of concept (edited)
mherchel	and to @Putra Bonaccorsi for working on #3093249: Implement tables on Olivero proof of concept (edited)
mherchel	I feel like i’m missing people… this is always the danger in explicitly thanking people!
Bhavin Joshi (he/him)	@shaal is this link available on issue (or queue)?
mherchel	But thanks to everyone else that is here and participating in the issue queues and with code!
shaal	@Bhavin Joshi (he/him) I created it manually, so it's a "custom board".
shaal	The other way to do it, is tag issues with a specific tag, and we can create a board that automatically is going to gather anything with that tag on it.